Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Pull Request Template Update #927

Merged
merged 5 commits into from
May 2, 2020
Merged

GitHub Pull Request Template Update #927

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c6ac1b
Updating changelog [ci skip]
jrnl-bot Apr 25, 2020
b0d3c29
Incrementing version to v2.4 [ci skip]
jrnl-bot Apr 25, 2020
13a49c7
Improve GitHub PR Template
minchinweb Apr 11, 2020
ae7b1e6
suggest running commands with `poetry run ...`
minchinweb Apr 27, 2020
3131889
Merge branch 'develop' into github-pr-template
wren May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@

<!--
# **TEMPLATE PLEASE EDIT**
*Thank you for wanting to contribute! Please fill out this description as well as look at the checklist!*
*Thank you for wanting to contribute! Please fill out this description as well
as look at the checklist!*

*Short block of text containing:
- Relevant changes in text form
Expand All @@ -9,11 +11,22 @@
- Example of usage (if applicable)
- Example of changes to config files (if applicable)
*
-->

### Checklist

- [ ] The code change is tested and works locally.
- [ ] Tests pass. Your PR cannot be merged unless tests pass
- [ ] Tests pass. Your PR cannot be merged unless tests pass. --
`poetry run behave`
- [ ] The code passes linting via
[black](https://black.readthedocs.io/en/stable/) (consistent code styling). --
`poetry run black --check . --verbose --diff`
- [ ] The code passes linting via [pyflakes](https://launchpad.net/pyflakes)
(logically errors and unused imports). -- `poetry run pyflakes jrnl features`
- [ ] There is no commented out code in this PR.
- [ ] Have you followed the guidelines in our Contributing document?
- [ ] Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?
- [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you checked to ensure there aren't other open
[Pull Requests](../pulls) for the same update/change?
- [ ] Have you added an explanation of what your changes do and why you'd like
us to include them?
- [ ] Have you written new tests for your core changes, as applicable?