Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

522 pre commit compatibillity issue with pythonpath #530

Conversation

niall-byrne
Copy link
Contributor

As mentioned previously there are some failing tests due to filename mangling, please have a look and suggest a resolution.
Thanks!

@niall-byrne niall-byrne changed the base branch from 522-pre-commit-compatibillity-issue-with-pythonpath to master January 28, 2025 17:03
@niall-byrne niall-byrne force-pushed the 522-pre-commit-compatibillity-issue-with-pythonpath branch from 9731618 to 2921fcb Compare January 28, 2025 22:10
@niall-byrne
Copy link
Contributor Author

I think I found a solution to attaching the class name to methods so the error messages are unchanged.

Please take a look.

@niall-byrne niall-byrne linked an issue Jan 28, 2025 that may be closed by this pull request
@niall-byrne niall-byrne force-pushed the 522-pre-commit-compatibillity-issue-with-pythonpath branch from 2921fcb to cb857b8 Compare January 28, 2025 22:19
@niall-byrne
Copy link
Contributor Author

Signed commit to make pre-commit checks happy.

@niall-byrne niall-byrne force-pushed the 522-pre-commit-compatibillity-issue-with-pythonpath branch from cb857b8 to d6ae16f Compare January 30, 2025 15:09
@jshwi
Copy link
Owner

jshwi commented Jan 31, 2025

Hey @niall-byrne
sorry, github actions is a bit more pedantic
can you please run make .make/format and push that
Pretty sure that's the last thing needed then I'll make the merge

@jshwi
Copy link
Owner

jshwi commented Jan 31, 2025

ah yeah, issue is, the docformatter pre-commit hook broke and was removed in 4e284b9
haven't reviewed it to see if it's been fixed yet: PyCQA/docformatter#293
well, the github action still works

Signed-off-by: Niall Byrne <[email protected]>
@niall-byrne niall-byrne force-pushed the 522-pre-commit-compatibillity-issue-with-pythonpath branch from d6ae16f to 1e74668 Compare January 31, 2025 11:08
@niall-byrne
Copy link
Contributor Author

niall-byrne commented Jan 31, 2025

@jshwi don't apologize for having setup good CI!
The formatter has been run manually as you suggested.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (db4d0cd) to head (1e74668).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         4189      4196    +7     
=========================================
+ Hits          4189      4196    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jshwi jshwi merged commit 1e74668 into jshwi:master Feb 1, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-Commit compatibillity issue with PYTHONPATH
2 participants