-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
522 pre commit compatibillity issue with pythonpath #530
522 pre commit compatibillity issue with pythonpath #530
Conversation
9731618
to
2921fcb
Compare
I think I found a solution to attaching the class name to methods so the error messages are unchanged. Please take a look. |
2921fcb
to
cb857b8
Compare
Signed commit to make pre-commit checks happy. |
cb857b8
to
d6ae16f
Compare
Hey @niall-byrne |
ah yeah, issue is, the |
Signed-off-by: Niall Byrne <[email protected]>
d6ae16f
to
1e74668
Compare
@jshwi don't apologize for having setup good CI! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 4189 4196 +7
=========================================
+ Hits 4189 4196 +7 ☔ View full report in Codecov by Sentry. |
As mentioned previously there are some failing tests due to filename mangling, please have a look and suggest a resolution.
Thanks!