Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official release still broken with pre-commit (1.7.6?) #293

Open
Eutropios opened this issue Oct 14, 2024 · 7 comments
Open

Official release still broken with pre-commit (1.7.6?) #293

Eutropios opened this issue Oct 14, 2024 · 7 comments
Labels
fresh This is a new issue

Comments

@Eutropios
Copy link

Despite the commit modifying docformatter to allow for it to work with pre-commit 4.0, this commit has not been shipped as an official release. Is there any chance we could get a 1.7.6 release with the latest commit to allow us to continue using docformatter as a pre-commit hook with 4.0?

@github-actions github-actions bot added the fresh This is a new issue label Oct 14, 2024
segsell added a commit to OpenSourceEconomics/dcegm that referenced this issue Oct 14, 2024
jshwi added a commit to jshwi/docsig that referenced this issue Oct 15, 2024
@GriceTurrble
Copy link

GriceTurrble commented Oct 17, 2024

Just a note, all that's required for pre-commit's autoupdate is to make a new tag in the repo. If folks want to avoid a full release when there may not be changes to the underlying package, that is.

I propose a v1.7.5-post1?

As a workaround, folks can target rev: "master" in their configs.

Edit: the most recent commit sha can also be used: rev: "eb1df347edd128b30cd3368dddc3aa65edcfac38"

@Niegazowana
Copy link

Niegazowana commented Nov 25, 2024

Hi, I see that there was some activity regarding this problem, are there no official news when the new release is planned?

srh-sloan pushed a commit to communitiesuk/funding-service-pre-award that referenced this issue Dec 2, 2024
Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
srh-sloan pushed a commit to communitiesuk/funding-service-pre-award that referenced this issue Dec 2, 2024
Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
srh-sloan pushed a commit to communitiesuk/funding-service-pre-award that referenced this issue Dec 2, 2024
Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
srh-sloan pushed a commit to communitiesuk/funding-service-pre-award that referenced this issue Dec 2, 2024
Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
@nfelt14
Copy link

nfelt14 commented Jan 8, 2025

Does anyone know who the primary maintainer of this package is so that we can get some progress made on this issue?

biolds added a commit to biolds/sosse that referenced this issue Jan 9, 2025
This uses a custom docformatter, since upstream repository is currently broken, see:
PyCQA/docformatter#293
felixhekhorn added a commit to NNPDF/eko that referenced this issue Jan 10, 2025
@mjspeck
Copy link

mjspeck commented Jan 16, 2025

Seriously, how are PRs being merged, but no releases are happening?

@Pierre-Sassoulas
Copy link
Member

It"s possible to use the commit sha instead of the version in pre-commit:

  - repo: https://github.com/PyCQA/docformatter
    rev: eb1df347edd128b30cd3368dddc3aa65edcfac38 # Don't autoupdate until https://github.com/PyCQA/docformatter/issues/293 is fixed
    hooks:
      - id: docformatter

(But pre-commit autoupdate will use a tag even if it's less recent than the sha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fresh This is a new issue
Projects
None yet
Development

No branches or pull requests

7 participants