-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rosnode for switchbot #260
Conversation
@k-okada By the way, I found the official Web API at https://github.com/OpenWonderLabs/SwitchBotAPI#getting-started . (To see the commit log, this API was released after my bthesis.) If we use it, I think we don't have to use the IFTTT anymore. Should I make |
I confirmed this API works with our lab's switchbots. |
I see , it make sense that switchbot_ros package uses SwitchBot API. |
Okay, I'll remake this package using API. |
@k-okada It's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR!
- Could you please add roseus function so that our robots can easily call
/switchbot_ros/goal
?
like below:
(defun control-switchbot (name action)
(cond ((equal action "xxx")
...
- What was the
DeviceType
of switchbot we have? Bot?
It would be helpful if you could give me a sample roseus code to turn on and off the lights in the 73B2 room.
https://github.com/OpenWonderLabs/SwitchBotAPI#send-device-control-commands
ok.
We have bot and meter I think. I'll make sample eus code later. |
for efficient python coding, you can use |
@knorth55 Thanks, I fixed. |
To use on eus, roslaunch switchbot_ros switchbot.launch token:=YOURTOKEN (load "package://switchbot_ros/scripts/switchbot.l")
;; Please setup your device name by your phone at first. Please see readme.
(control-device "/eng2/7f/73b2/light1" "turnOn") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, but I found few more changes.
Okay, I fixed. |
Was the travis timeout? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mqcmd196 please add elevator example, also create an image/slide that explain this system
…n name, fix rosnode file for changing action name
I updated README |
The rosnode for using switchbot.