Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for jsk-ros-pkg/jsk_common/pull/1586 #2311

Merged
merged 5 commits into from
Aug 3, 2018
Merged

fix for jsk-ros-pkg/jsk_common/pull/1586 #2311

merged 5 commits into from
Aug 3, 2018

Conversation

furushchev
Copy link
Member

@furushchev furushchev commented Aug 1, 2018 •
edited by k-okada
Loading

fix regression by jsk-ros-pkg/jsk_common#1586

@furushchev furushchev requested review from k-okada and wkentaro August 1, 2018 14:25
@k-okada
to avoid add_custom_target cannot create target install_sample_data b…
949bfe4 
…ecause

another target with the same name already exists errors
k-okada
k-okada approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for trouble @furushchev

@k-okada k-okada merged commit 7801eca into jsk-ros-pkg:master Aug 3, 2018
@furushchev furushchev deleted the imagesift branch August 3, 2018 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada approved these changes

@wkentaro wkentaro wkentaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furushchev @k-okada @wkentaro