Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building unnecessary packages on indigo to speed up travis #1179

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

pazeshun
Copy link
Contributor

@pazeshun pazeshun commented Nov 18, 2019

Includes #1171

With #1017, whole jsk_3rdparty is included in workspace on travis (created with .travis.rosinstall.indigo) for jsk_fetch_startup.
But actually, we need respeaker_ros only.
Also see #1171 (comment)

Other minor fix: upload apt-cacher-ng cache to speed up rosdep install (effective from second time)
See #1171 (comment)

YutoUchimi and others added 2 commits November 12, 2019 10:46
With jsk-ros-pkg#1017, whole jsk_3rdparty is included in workspace on travis for jsk_fetch_startup, but we need respeaker_ros only
Also see jsk-ros-pkg#1171 (comment)
@pazeshun
Copy link
Contributor Author

pazeshun commented Nov 18, 2019

catkin_build becomes much shorter:

This PR #1171
catkin_build 4 min 32 sec 13 min 44 sec

@pazeshun
Copy link
Contributor Author

@knorth55 @YutoUchimi
I cherry-pick one commit in #1177 , because #1177 may take some time for review.
Sorry, but could you review again?

@YutoUchimi YutoUchimi added this to the 1.1.1 milestone Nov 19, 2019
@pazeshun pazeshun removed the request for review from 708yamaguchi November 19, 2019 08:40
@pazeshun
Copy link
Contributor Author

@k-okada
Currently, jsk_robot repository has many PRs, but many of them failed on travis due to timeout.
This PR can probably fix that.
I, @knorth55 and @YutoUchimi agreed that we had better review & merge this PR first to make travis stable.
Could you review this?

@k-okada k-okada merged commit 8c50a76 into jsk-ros-pkg:master Nov 19, 2019
@pazeshun
Copy link
Contributor Author

Thank you!!!

@pazeshun pazeshun deleted the decrease-travis-rosinstall branch November 19, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants