[jsk_fetch_startup] Do not replace sound when other node is speaking #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knorth55
changed the title
knorth55
force-pushed
the
fetch-sound-no-replace
branch
from
2d275f7 to
f7b235a
Compare
There was a problem hiding this comment.
jsk_fetch.rosinstall.melodic and battery_warning.py seems good.
But boot_sound.py does not reflect #1262
I create PR to reflect #1262, and I check this PR today.
knorth55#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR enables fetch to wait speaking until other node is speaking.
cc. @708yamaguchi
related: ros-drivers/audio_common#173