Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sound_play] add replace arg in sendMsg #173

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

knorth55
Copy link
Member

I add replace argument in sendMsg.

when replace is true, SoundClient replace the audio commands. (default)
when replace is false, SoundClient waits until previous commands finish.

cc. @708yamaguchi

@knorth55 knorth55 changed the title add replace in sendMsg [sound_play] add replace arg in sendMsg Jul 16, 2021
@knorth55
Copy link
Member Author

@708yamaguchi have you done checking this feature?

@708yamaguchi
Copy link
Contributor

Yes, thank you.

I checked that replace=False works nicely.
SoundClient can wait for other nodes to finish speaking.

@knorth55 knorth55 merged commit 75a126e into ros-drivers:master Jul 19, 2021
@knorth55 knorth55 deleted the replace-sound-client branch July 19, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants