Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] Update trashcan front position in kitchen demo #1462

Merged

Conversation

tkmtnt7000
Copy link
Member

@tkmtnt7000 tkmtnt7000 commented Apr 20, 2022

Please merge after #1458.
I cherry-picked knorth55#142 and knorth55#153.

I updated trashcan front position for Fetch to move faster around the trashcan than before.

@tkmtnt7000 tkmtnt7000 changed the title [jsk_fetch_startup] Update trashcan front position in kitchen demo [Merge after #1458] [jsk_fetch_startup] Update trashcan front position in kitchen demo Apr 20, 2022
@k-okada
Copy link
Member

k-okada commented Apr 21, 2022

please see comments #1463 (comment)

@tkmtnt7000 tkmtnt7000 force-pushed the update-trashbin-position-master branch from 0f6b352 to c49a465 Compare April 22, 2022 05:24
@tkmtnt7000
Copy link
Member Author

tkmtnt7000 commented Apr 22, 2022

I rebased 708yamaguchi/use-relative-coords #1458 to resolve conflicts and catch up origin/master.

@k-okada
Copy link
Member

k-okada commented May 24, 2022

NeedDiscussion -> Did we embed images within the mail?

@knorth55 knorth55 changed the title [Merge after #1458] [jsk_fetch_startup] Update trashcan front position in kitchen demo [jsk_fetch_startup] Update trashcan front position in kitchen demo Jul 20, 2022
@tkmtnt7000 tkmtnt7000 force-pushed the update-trashbin-position-master branch from c49a465 to d73cabf Compare July 21, 2022 05:50
@tkmtnt7000
Copy link
Member Author

I rebased current jsk-ros-pkg/jsk_robot master branch to resolve conflicts.

@k-okada k-okada merged commit 153a248 into jsk-ros-pkg:master Jul 21, 2022
@tkmtnt7000 tkmtnt7000 deleted the update-trashbin-position-master branch July 21, 2022 07:51
@tkmtnt7000 tkmtnt7000 restored the update-trashbin-position-master branch July 21, 2022 07:53
@tkmtnt7000 tkmtnt7000 deleted the update-trashbin-position-master branch July 21, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants