-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch notifies trashbox status in go-to-kitchen demo. #1458
Fetch notifies trashbox status in go-to-kitchen demo. #1458
Conversation
please paste screenshot of notification mail @708yamaguchi |
please see comments #1463 (comment) |
fd50963
to
8a9b8ee
Compare
I rebased |
@708yamaguchi please resolve conflicts |
8a9b8ee
to
0bd3601
Compare
I rebase the current |
@@ -140,8 +140,7 @@ | |||
(if is-charging :charging :discharging))) | |||
|
|||
|
|||
(defun go-to-spot (name &optional (relative-coords (make-coords)) | |||
&key (undock-rotate nil) (clear-costmap t)) | |||
(defun go-to-spot (name &key (relative-pos nil) (relative-rot nil) (undock-rotate nil) (clear-costmap t)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we ok to change API?
Specially why you changed coordinates to pos/rot?
since go-to-spot will be put in pr2eus level in future, please add documentation string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your review.
As you pointed out, documentation was lacking, so I added an explanation. 268ea1c
(#1458)
After talking with @tkmtnt7000, we came to the conclusion that it is easier to understand if relative-pos and relative-rot are specified in the different coords (specifically, world (map) and local (spot) coords respectively).
knorth55#140 (comment)
For example, assume using relative-coords in each spot's coords.
In this case, when specifying the pos of the relative-coords, we need to care about the orientation of each spot.
This is very complicated because each spot has a different orientation.
Please merge after #1449I cherry-picked
With this PR,