[#454] Fix for aria-proptypes rule failure #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for #454 |
ljharb
approved these changes
Jul 4, 2018
|
Hi, when will merge this pr? thanks |
This was referenced Jul 6, 2018
|
Thanks for the hard work here guys. Really appreciate the project; any timeline for when this commit will be released as 6.1.1? |
|
See #461 |
|
@chrisopedia We just need to get #464 approved and landed. |
dimaip
referenced
this pull request
in dimaip/neos-ui
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idis now treated as a stringidlistis a comma-delimited list of strings.We can probably do more to discourage values like
"false"and"null", but I want to get a fix out quick for the new version.