Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-proptypes support for idlist #454

Closed
oliviertassinari opened this issue Jul 3, 2018 · 4 comments
Closed

aria-proptypes support for idlist #454

oliviertassinari opened this issue Jul 3, 2018 · 4 comments
Assignees

Comments

@oliviertassinari
Copy link

I have noticed the following errors on Material-UI side trying to upgrade this dependency:
capture d ecran 2018-07-03 a 21 53 16

The following aria seem to not be supported as expected:

  • aria-labelledby
  • aria-controls
  • aria-describedby

arial-query returns the type idlist. Something that is not supported in the implementation: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/b800f40a2a69ad48015ae9226fbe879f946757ed/src/rules/aria-proptypes.js#L32

@ljharb
Copy link
Member

ljharb commented Jul 3, 2018

This is affecting the airbnb config as well, fwiw.

@jessebeach
Copy link
Collaborator

I'll get this fixed tonight.

6.2.0 update is on the way :)

@jessebeach
Copy link
Collaborator

Here's the change in aria-query that is causing the errors: A11yance/aria-query@6978637

What I don't yet understand is why none of the tests in this repo caught this. I don't want to simply update aria-query without getting a test case to fail here first so we don't have something like this happen again in the future.

@ljharb
Copy link
Member

ljharb commented Jul 6, 2018

Closed in #456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants