Default config for non heroku environments

[jasonsbrooks]

The default config for non Heroku environments is currently set as follows:

judoscale-python/judoscale/core/config.py

Line 53 in e101123

return cls(None, "", env)

so API_BASE_URL is set as an empty string.

The code that determines if Judoscale should run, though, seems to compare API_BASE_URL against None:

judoscale-python/judoscale/django/apps.py

Line 20 in e101123

if judoconfig["API_BASE_URL"] is None:

We've been seeing Judoscale attempting to run locally on our dev machines, and pretty sure it's because this check is returning True.

Should the default config instead return return cls(None, None, env) so the API_BASE_URL is set to None instead of ""? Or alternatively should the check be if judoconfig["API_BASE_URL"]:? Happy to put up a pull request if this seems reasonable.

[karls]

Hey @jasonsbrooks,

Thanks for this bug report. I'm able to reproduce this locally and I'm going to patch this today.

[jasonsbrooks]

Awesome, thanks so much @karls !

[karls]

Hey @jasonsbrooks,

I've just released 1.4.1, which should fix the issue you're seeing. 🙌🏻