Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle missing API_BASE_URL #60

Merged
merged 2 commits into from
Apr 28, 2023
Merged

fix: Handle missing API_BASE_URL #60

merged 2 commits into from
Apr 28, 2023

Conversation

karls
Copy link
Collaborator

@karls karls commented Apr 27, 2023

Fixes #59.

@karls karls requested a review from adamlogic April 27, 2023 17:52
@karls
Copy link
Collaborator Author

karls commented Apr 27, 2023

@adamlogic there's some extra noise again due to updating sample apps as well. The first commit (e4b9a77) is the library change, and the second commit (bb764df) is the sample apps change. Just FYI. 🙂

adamlogic
adamlogic approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@adamlogic adamlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@karls karls merged commit 79f2753 into main Apr 28, 2023
@karls karls deleted the fix-missing-api-base-url branch April 28, 2023 07:49
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamlogic adamlogic adamlogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default config for non heroku environments
2 participants
@karls @adamlogic