Skip to content

Commit

Permalink
Trim trailing whitespace in SDK's codebase(aws#2489)
Browse files Browse the repository at this point in the history
Updates the SDK's codebase trimming out trailing whitespace from non-model, and generated code files.
  • Loading branch information
mikecook authored and jasdel committed Mar 8, 2019
1 parent 7e7bb32 commit b2eca01
Show file tree
Hide file tree
Showing 31 changed files with 112 additions and 112 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ matrix:

script:
- if [ $TRAVIS_GO_VERSION == "tip" ] ||
[ $TRAVIS_GO_VERSION == "1.11.x" ] ||
[ $TRAVIS_GO_VERSION == "1.11.x" ] ||
[ $TRAVIS_GO_VERSION == "1.10.x" ]; then
make ci-test;
else
Expand Down
18 changes: 9 additions & 9 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2206,10 +2206,10 @@ Release v1.13.55 (2018-05-24)
* This release adds CloudWatch Logs integration capabilities to RDS Aurora MySQL clusters
* `service/secretsmanager`: Updates service documentation
* Documentation updates for secretsmanager

### SDK Bugs
* `service/cloudwatchlogs`: Fix pagination with cloudwatchlogs ([#1945](https://github.com/aws/aws-sdk-go/pull/1945))
* Fixes the SDK's behavior with CloudWatchLogs APIs which return duplicate `NextToken` values to signal end of pagination.
* Fixes the SDK's behavior with CloudWatchLogs APIs which return duplicate `NextToken` values to signal end of pagination.
* Fixes [#1908](https://github.com/aws/aws-sdk-go/pull/1908)

Release v1.13.54 (2018-05-22)
Expand Down Expand Up @@ -2876,7 +2876,7 @@ Release v1.12.72 (2018-02-07)
* `private/model/api`: Add validation to ensure there is no duplication of services in models/apis ([#1758](https://github.com/aws/aws-sdk-go/pull/1758))
* Prevents the SDK from mistakenly generating code a single service multiple times with different model versions.
* `example/service/ec2/instancesbyRegion`: Fix typos in example ([#1762](https://github.com/aws/aws-sdk-go/pull/1762))
* `private/model/api`: removing SDK API reference crosslinks from input/output shapes. (#1765)
* `private/model/api`: removing SDK API reference crosslinks from input/output shapes. (#1765)

### SDK Bugs
* `aws/session`: Fix bug in session.New not supporting AWS_SDK_LOAD_CONFIG ([#1770](https://github.com/aws/aws-sdk-go/pull/1770))
Expand Down Expand Up @@ -4273,7 +4273,7 @@ Release v1.9.00 (2017-06-19)
### SDK Features
* `service/s3/s3manager`: Adds batch operations to s3manager [#1333](https://github.com/aws/aws-sdk-go/pull/1333)
* Allows for batch upload, download, and delete of objects. Also adds the interface pattern to allow for easy traversal of objects. E.G `DownloadWithIterator`, `UploadWithIterator`, and `BatchDelete`. `BatchDelete` also contains a utility iterator using the `ListObjects` API to easily delete a list of objects.

Release v1.8.44 (2017-06-16)
===

Expand Down Expand Up @@ -4508,7 +4508,7 @@ Release v1.8.23 (2017-05-15)

### SDK Enhancements
* `aws/session`: SDK should be able to load multiple custom shared config files. [#1258](https://github.com/aws/aws-sdk-go/issues/1258)
* This change adds a `SharedConfigFiles` field to the `session.Options` type that allows you to specify the files, and their order, the SDK will use for loading shared configuration and credentials from when the `Session` is created. Use the `NewSessionWithOptions` Session constructor to specify these options. You'll also most likely want to enable support for the shared configuration file's additional attributes by setting `session.Option`'s `SharedConfigState` to `session.SharedConfigEnabled`.
* This change adds a `SharedConfigFiles` field to the `session.Options` type that allows you to specify the files, and their order, the SDK will use for loading shared configuration and credentials from when the `Session` is created. Use the `NewSessionWithOptions` Session constructor to specify these options. You'll also most likely want to enable support for the shared configuration file's additional attributes by setting `session.Option`'s `SharedConfigState` to `session.SharedConfigEnabled`.

Release v1.8.22 (2017-05-11)
===
Expand Down Expand Up @@ -4815,7 +4815,7 @@ SDK Features
SDK Enhancements
---
* `aws/signer/v4`: Adds support for unsigned payload signer config (#1130)
* Adds configuration option to the v4.Signer to specify the request's body should not be signed. This will only correclty function on services that support unsigned payload. e.g. S3, Glacier.
* Adds configuration option to the v4.Signer to specify the request's body should not be signed. This will only correclty function on services that support unsigned payload. e.g. S3, Glacier.

SDK Bug Fixes
---
Expand Down Expand Up @@ -5375,7 +5375,7 @@ Service Client Updates
SDK Bug Fixes
---
* `private/protocol/xml/xmlutil`: Fixes xml marshaler to unmarshal properly
into tagged fields
into tagged fields
[#916](https://github.com/aws/aws-sdk-go/issues/916)

Release v1.5.9 (2016-11-22)
Expand Down Expand Up @@ -5464,7 +5464,7 @@ Service Client Updates
SDK Feature Updates
---
* `private/model/api`: Add generated setters for API parameters (#918)
* Adds setters to the SDK's API parameter types, and are a convenience method that reduce the need to use `aws.String` and like utility.
* Adds setters to the SDK's API parameter types, and are a convenience method that reduce the need to use `aws.String` and like utility.

Release v1.4.22 (2016-10-25)
===
Expand Down Expand Up @@ -5544,7 +5544,7 @@ Service Model Updates
* `service/ecr`: Update Amazon EC2 Container Registry service model
* DescribeImages is a new api used to expose image metadata which today includes image size and image creation timestamp.
* `service/elasticache`: Update Amazon ElastiCache service model
* Elasticache is launching a new major engine release of Redis, 3.2 (providing stability updates and new command sets over 2.8), as well as ElasticSupport for enabling Redis Cluster in 3.2, which provides support for multiple node groups to horizontally scale data, as well as superior engine failover capabilities
* Elasticache is launching a new major engine release of Redis, 3.2 (providing stability updates and new command sets over 2.8), as well as ElasticSupport for enabling Redis Cluster in 3.2, which provides support for multiple node groups to horizontally scale data, as well as superior engine failover capabilities

SDK Bug Fixes
---
Expand Down
4 changes: 2 additions & 2 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## Code of Conduct
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
[email protected] with any additional questions or comments.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Please be aware of the following notes prior to opening a pull request:

3. Wherever possible, pull requests should contain tests as appropriate.
Bugfixes should contain tests that exercise the corrected behavior (i.e., the
test should fail without the bugfix and pass with it), and new features
test should fail without the bugfix and pass with it), and new features
should be accompanied by tests exercising the feature.

4. Pull requests that contain failing tests will not be merged until the test
Expand All @@ -71,7 +71,7 @@ Please be aware of the following notes prior to opening a pull request:

### Testing

To run the tests locally, running the `make unit` command will `go get` the
To run the tests locally, running the `make unit` command will `go get` the
SDK's testing dependencies, and run vet, link and unit tests for the SDK.

```
Expand All @@ -88,7 +88,7 @@ go test -tags codegen ./private/...

See the `Makefile` for additional testing tags that can be used in testing.

To test on multiple platform the SDK includes several DockerFiles under the
To test on multiple platform the SDK includes several DockerFiles under the
`awstesting/sandbox` folder, and associated make recipes to execute
unit testing within environments configured for specific Go versions.

Expand Down
2 changes: 1 addition & 1 deletion NOTICE.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
AWS SDK for Go
Copyright 2015 Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copyright 2015 Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copyright 2014-2015 Stripe, Inc.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ aws-sdk-go is the official AWS SDK for the Go programming language.
Checkout our [release notes](https://github.com/aws/aws-sdk-go/releases) for
information about the latest bug fixes, updates, and features added to the SDK.

We [announced](https://aws.amazon.com/blogs/developer/aws-sdk-for-go-2-0-developer-preview/) the Developer Preview for the [v2 AWS SDK for Go](https://github.com/aws/aws-sdk-go-v2). The v2 SDK source is available at https://github.com/aws/aws-sdk-go-v2, and add it to your project with `go get github.com/aws/aws-sdk-go-v2`. Check out the v2 SDK's [changes and updates](https://github.com/aws/aws-sdk-go-v2/blob/master/CHANGELOG.md), and let us know what you think. We want your feedback.
We [announced](https://aws.amazon.com/blogs/developer/aws-sdk-for-go-2-0-developer-preview/) the Developer Preview for the [v2 AWS SDK for Go](https://github.com/aws/aws-sdk-go-v2). The v2 SDK source is available at https://github.com/aws/aws-sdk-go-v2, and add it to your project with `go get github.com/aws/aws-sdk-go-v2`. Check out the v2 SDK's [changes and updates](https://github.com/aws/aws-sdk-go-v2/blob/master/CHANGELOG.md), and let us know what you think. We want your feedback.

## Installing

Expand Down
8 changes: 4 additions & 4 deletions aws/credentials/processcreds/testdata/expired.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Version": 1,
"AccessKeyId": "accessKey",
"SecretAccessKey": "secret",
"SessionToken": "tokenDefault",
"Version": 1,
"AccessKeyId": "accessKey",
"SecretAccessKey": "secret",
"SessionToken": "tokenDefault",
"Expiration": "2000-01-01T00:00:00-00:00"
}
2 changes: 1 addition & 1 deletion aws/credentials/processcreds/testdata/missingsecret.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"Version": 1,
"Version": 1,
"SecretAccessKey": "secretkey"
}
6 changes: 3 additions & 3 deletions aws/credentials/processcreds/testdata/nonexpire.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"Version": 1,
"AccessKeyId": "accessKey",
"SecretAccessKey": "secret",
"Version": 1,
"AccessKeyId": "accessKey",
"SecretAccessKey": "secret",
"SessionToken": "nonDefaultToken"
}
4 changes: 2 additions & 2 deletions aws/credentials/processcreds/testdata/shconfig.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
credential_process = cat ./testdata/expired.json

[profile non_expire]
credential_process = cat ./testdata/nonexpire.json
credential_process = cat ./testdata/nonexpire.json

[profile not_alone]
aws_access_key_id = notFromCredProcAccess
aws_secret_access_key = notFromCredProcSecret
credential_process = cat ./testdata/verybad.json
credential_process = cat ./testdata/verybad.json
2 changes: 1 addition & 1 deletion aws/credentials/processcreds/testdata/shconfig_win.ini
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ credential_process = type .\testdata\nonexpire.json
[profile not_alone]
aws_access_key_id = notFromCredProcAccess
aws_secret_access_key = notFromCredProcSecret
credential_process = type .\testdata\verybad.json
credential_process = type .\testdata\verybad.json
4 changes: 2 additions & 2 deletions aws/credentials/processcreds/testdata/shcred.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
credential_process = cat ./testdata/expired.json

[non_expire]
credential_process = cat ./testdata/nonexpire.json
credential_process = cat ./testdata/nonexpire.json

[not_alone]
aws_access_key_id = notFromCredProcAccess
aws_secret_access_key = notFromCredProcSecret
credential_process = cat ./testdata/verybad.json
credential_process = cat ./testdata/verybad.json
2 changes: 1 addition & 1 deletion aws/credentials/processcreds/testdata/shcred_win.ini
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ credential_process = type .\testdata\nonexpire.json
[not_alone]
aws_access_key_id = notFromCredProcAccess
aws_secret_access_key = notFromCredProcSecret
credential_process = type .\testdata\verybad.json
credential_process = type .\testdata\verybad.json
2 changes: 1 addition & 1 deletion awstesting/sandbox/Dockerfile.golang-tip
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ RUN export GOROOT_BOOTSTRAP=$GOLANG_BOOTSTRAP_PATH/go \
&& git clone "$GOLANG_SRC_REPO_URL" /usr/local/go \
&& cd /usr/local/go/src \
&& ./make.bash \
&& rm -rf "$GOLANG_BOOTSTRAP_PATH" /usr/local/go/pkg/bootstrap
&& rm -rf "$GOLANG_BOOTSTRAP_PATH" /usr/local/go/pkg/bootstrap

# Build Go workspace and environment
ENV GOPATH /go
Expand Down
18 changes: 9 additions & 9 deletions doc-src/aws-godoc/templates/godoc.html
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@
pageOldStyle.display = page.style.display;
page.style.display = "none";

divOldStyle.fontSize = div.style.fontSize;
divOldStyle.lineHeight = div.style.lineHeight;
divOldStyle.display = div.style.display;
div.style.fontSize = "x-large";
div.style.lineHeight = "150%";
div.style.display = "inline-block";
divOldStyle.fontSize = div.style.fontSize;
divOldStyle.lineHeight = div.style.lineHeight;
divOldStyle.display = div.style.display;
div.style.fontSize = "x-large";
div.style.lineHeight = "150%";
div.style.display = "inline-block";
which = false;
}

Expand All @@ -88,9 +88,9 @@

page.style.display = pageOldStyle.display;

div.style.fontSize = divOldStyle.fontSize;
div.style.lineHeight = divOldStyle.lineHeight;
div.style.display = divOldStyle.display;
div.style.fontSize = divOldStyle.fontSize;
div.style.lineHeight = divOldStyle.lineHeight;
div.style.display = divOldStyle.display;
which = true;
}

Expand Down
2 changes: 1 addition & 1 deletion doc-src/aws-godoc/templates/godocs.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ function setupInlinePlayground() {
code.on('keyup', resize);
code.keyup(); // resize now.
};

// If example already visible, set up playground now.
if ($(el).is(':visible')) {
setup();
Expand Down
2 changes: 1 addition & 1 deletion doc-src/aws-godoc/templates/jquery.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion doc-src/aws-godoc/templates/jquery.treeview.edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@
}
});
};

})(jQuery);
42 changes: 21 additions & 21 deletions doc-src/aws-godoc/templates/jquery.treeview.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Treeview 1.4.1 - jQuery plugin to hide and show branches of a tree
*
*
* http://bassistance.de/jquery-plugins/jquery-plugin-treeview/
* http://docs.jquery.com/Plugins/Treeview
*
Expand Down Expand Up @@ -50,7 +50,7 @@
} else {
this.hide();
if (callback)
this.each(callback);
this.each(callback);
}
},
prepareBranches: function(settings) {
Expand All @@ -70,18 +70,18 @@
if ( this == event.target )
toggler.apply($(this).next());
}).add( $("a", this) ).hoverClass();

if (!settings.prerendered) {
// handle closed ones first
this.filter(":has(>ul:hidden)")
.addClass(CLASSES.expandable)
.replaceClass(CLASSES.last, CLASSES.lastExpandable);

// handle open ones
this.not(":has(>ul:hidden)")
.addClass(CLASSES.collapsable)
.replaceClass(CLASSES.last, CLASSES.lastCollapsable);

// create hitarea if not present
var hitarea = this.find("div." + CLASSES.hitarea);
if (!hitarea.length)
Expand All @@ -94,23 +94,23 @@
$(this).addClass( classes );
})
}

// apply event to hitarea
this.find("div." + CLASSES.hitarea).click( toggler );
},
treeview: function(settings) {

settings = $.extend({
cookieId: "treeview"
}, settings);

if ( settings.toggle ) {
var callback = settings.toggle;
settings.toggle = function() {
return callback.apply($(this).parent()[0], arguments);
};
}

// factory for treecontroller
function treeController(tree, control) {
// factory for click handlers
Expand All @@ -130,9 +130,9 @@
// click on second to expand tree
$("a:eq(1)", control).click( handler(CLASSES.expandable) );
// click on third to toggle tree
$("a:eq(2)", control).click( handler() );
$("a:eq(2)", control).click( handler() );
}

// handle toggle event
function toggler() {
$(this)
Expand Down Expand Up @@ -164,7 +164,7 @@
}
}
this.data("toggler", toggler);

function serialize() {
function binary(arg) {
return arg ? 1 : 0;
Expand All @@ -175,7 +175,7 @@
});
$.cookie(settings.cookieId, data.join(""), settings.cookieOptions );
}

function deserialize() {
var stored = $.cookie(settings.cookieId);
if ( stored ) {
Expand All @@ -185,13 +185,13 @@
});
}
}

// add treeview class to activate styles
this.addClass("treeview");

// prepare branches and find all tree items with child lists
var branches = this.find("li").prepareBranches(settings);

switch(settings.persist) {
case "cookie":
var toggleCallback = settings.toggle;
Expand Down Expand Up @@ -222,19 +222,19 @@
}
break;
}

branches.applyClasses(settings, toggler);

// if control option is set, create the treecontroller and show it
if ( settings.control ) {
treeController(this, settings.control);
$(settings.control).show();
}

return this;
}
});

// classes used by the plugin
// need to be styled via external stylesheet, see first example
$.treeview = {};
Expand All @@ -252,5 +252,5 @@
last: "last",
hitarea: "hitarea"
});

})(jQuery);
Loading

0 comments on commit b2eca01

Please sign in to comment.