🌎 Fetch config extensions from URL #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwkoch
commented
May 28, 2024
| ) { | ||
| let message: string; | ||
| let message: string | undefined; | ||
| if (opts?.allowRemote && isUrl(relativePath)) { |
There was a problem hiding this comment.
👀 This is the "interesting" part of the PR. Everything else is async/await...
|
Add note to docs for this!- Included in docs update in #1266 |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extendspr was added here to allow one myst.yml to extend another: #1215In that PR and in this issue #336 the next step was allowing remote urls for the extend content so centralized data may be reused across users/projects. This PR adds that remote resolution step!
Biggest thing about this pr is going from sync to async at the config loading level; this means many functions are newly awaited... big diff minor impact.