🔧 Resolve toc patterns in intentional order #1266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new project
toc
s introduced support forpattern
entries, where users may specify a glob pattern as part of their tree. However, these were just getting resolved to a flat list of files, ordered by default system ordering.This PR adds much more explicit handling of patterns.
glob
is still used to collect the files, but then we:file
that is also part of apattern
, it will not show up in the resolved pattern treeexclude
from project frontmatterThese changes mean pattern resolution is similar to the implicit project resolution, with a few small differences:
_build
,node_modules
,.*
- they can still be ignored withexclude
This addresses #1244 - it also addresses #1243 in the process, since we resolve patterns to create a new tree without patterns.