feat: backward compatibility with 7.x #3358
Conversation
This way widget libraries accessing JupyterPhosphorWidget and/or pWidget can run with 8.x without making a 7.x incompatible build.
|
|
|
Thanks! As per the discussion at the team meeting on Tuesday, we should get this in! |
packages/base/src/widget.ts
Outdated
| */ | ||
| get pWidget(): Widget { | ||
| if (!DOMWidgetView.deprecationWarningDisplayed) { | ||
| console.warn( |
There was a problem hiding this comment.
This is going to put a lot of warnings in consoles of users that cannot do anything about it as soon as we release. Perhaps we can start off deleting this console.warn, with just docs saying it is deprecated, then up it to a console warning later to put more pressure on migrating?
There was a problem hiding this comment.
The intention of this code was to maximally show one warning per page load. I can't see how this would happen more often, maybe I'm missing something? If one message is still too much, I'm still fine with taking it out.
There was a problem hiding this comment.
Sorry, I meant that lots of users will have this warning, not that it would show up a lot of times on a single page. I think it's gentler to give developers a chance to migrate before showing warnings to their users.
|
@jasongrout @mariobuikhuizen Should we do an alias for cc. @ibdafna |
|
Yeah, I'm for it. It just wasn't an issue in ipyvue. |
|
Thanks a lot @mariobuikhuizen ! I was thinking about it this morning, it's unclear to me how this would look like for someone who wants to still support ipywidgets<8 (they need to overwrite |
|
Ok, so it's used with overriding (looking at https://github.com/bqplot/bqplot/blob/dbc639836e58909250cf2ceb93aaca9e2c77d3d8/js/src/Figure.ts#L743). I don't know a solution to that off the top of my head. I will think about it for a bit. |
This way widget libraries accessing
JupyterPhosphorWidgetand/orpWidgetcan run with 8.x without making a 7.x incompatible build.For example: