Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backward compatibility with 7.x #3358

Merged
merged 2 commits into from
Jan 28, 2022
+13 −0
Merged

feat: backward compatibility with 7.x #3358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1e0724
feat: backward compatibility with 7.x
mariobuikhuizen Jan 26, 2022
9e45585
fix: remove deprecation warning form console
mariobuikhuizen Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/base/src/widget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,11 @@ export class JupyterLuminoWidget extends Widget {
private _view: DOMWidgetView;
}

/**
* @deprecated Use {@link JupyterLuminoWidget} instead (Since 8.0).
*/
export const JupyterPhosphorWidget = JupyterLuminoWidget;

export class JupyterLuminoPanelWidget extends Panel {
constructor(options: JupyterLuminoWidget.IOptions & Panel.IOptions) {
const view = options.view;
Expand Down Expand Up @@ -1167,6 +1172,14 @@ export class DOMWidgetView extends WidgetView {
this.el.removeAttribute('tabIndex');
}
}

/**
* @deprecated Use {@link luminoWidget} instead (Since 8.0).
*/
get pWidget(): Widget {
return this.luminoWidget;
}

el: HTMLElement; // Override typing
'$el': any;
luminoWidget: Widget;
Expand Down