Added debugger key in kernel_info_reply #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Thanks @JohanMabille! This will be useful for clients who want to offer debugging capabilities only when a kernel supports debugging.
|
My approval does not mean "ready to merge" as much as it means 👍 I know there are a multiple stakeholders here who might have thoughts on this. |
kevin-bates
approved these changes
Oct 30, 2019
SylvainCorlay
force-pushed
the
master
branch
from
b1fe8e4 to
3e8ee4a
Compare
|
@JohanMabille I've added this to the 7.0 milestone, can you please rebase? |
|
@blink1073 sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding the 'debugger' key toe the
kernel_info_replymessage to signal the frontent if it can start a debugging session.We may map a more complicated structure to this key, to specify subparts of the Debug Adapter protocol that are supported for instance (or any additional requirement).