Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Check for kernel debugging capabilities #167

Closed
jtpio opened this issue Nov 11, 2019 · 1 comment · Fixed by #201
Closed

Check for kernel debugging capabilities #167

jtpio opened this issue Nov 11, 2019 · 1 comment · Fixed by #201
Assignees
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Nov 11, 2019

We should check whether a kernel has debugging capabilities or not before starting the debugger.

Related TODO:

debugger/src/service.ts

Lines 28 to 29 in f641270

// TODO: also checks that the notebook or console
// runs a kernel with debugging ability

There is a PR to add the debugger flag for kernel_info_reply in jupyter_client: jupyter/jupyter_client#486

In the meantime we can create an interface that extends IInfoReply and adds the debugger flag.

@jtpio jtpio added this to the 0.1.0 milestone Nov 11, 2019
@jtpio jtpio self-assigned this Nov 18, 2019
@jtpio
Copy link
Member Author

jtpio commented Nov 18, 2019

We can start by adding that to the interface and to the tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant