Work on the style and usability of find and replace... #741
Conversation
ellisonbg
commented
Nov 21, 2015
ellisonbg
commented
- Using the align-left logo for the find in selection. We looked through various UIs and got this idea from Visual Studio Code. Still not perfect, but @jdfreder and I think it is an improvement.
- Small size input fields and buttons for more efficient usage of space.
- Bits of code organization.
closes #558 |
| .attr('title', 'Use regex (JavaScript regex syntax)') | ||
| .text('.*'); | ||
|
|
||
| var onlySelectedButton = $('<button/>') | ||
| var onlySelectedButton = $('<button><i class="fa fa-align-left"/></button>') |
There was a problem hiding this comment.
doing that with jquery is bad. $() is not ment for templating, and it's inconsistent will al the rest of our code, like we won't be able to for an grep addClass | grep fa-align
|
Thanks for the cleanup. |
|
For more compactness : pre.replace {
padding:3px
}Thoughts ? |
|
On the padding. Using 3px seemed a bit tight, but here is a padding of
I think this looks good and definitely fits more than before. |
|
OK all changes are pushed and should be ready to go... |
|
That's looking pretty good to me. I'll let @Carreau merge. |
|
+1 thanks ! Happy to see you submitting PRs ! |
Work on the style and usability of find and replace...
|
I'm thinking in using lighter red and green for match and delete. Thoughts? |
|
Sure I will try that now... On Wed, Nov 25, 2015 at 4:31 AM, Matthias Bussonnier <
Brian E. Granger |
|
Opps, did I merge this? Didn't mean to do that. But everything other than the colors is final so I think we are OK. I will create a seaprate PR for the color changes. After playing, I do like lighter colors. |
No I did, the color was a suggestion for separate PR. |
|
Ahh OK, other PR is submitted :) On Wed, Nov 25, 2015 at 9:25 AM, Matthias Bussonnier <
Brian E. Granger |
