Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing colors on find and replace matches. #757

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

ellisonbg
Copy link
Contributor

This is a follow up to #741 which lightens the colors of the find and replace matches and uses Material Design colors.

@ellisonbg
Copy link
Contributor Author

Option A)

  • MD Blue 50/100
  • MD Green and Red 200/300

screen shot 2015-11-25 at 8 47 49 am

screen shot 2015-11-25 at 8 47 59 am

@ellisonbg
Copy link
Contributor Author

Option B)

  • MD Blue, Green, Red 100/200

screen shot 2015-11-25 at 8 50 00 am

screen shot 2015-11-25 at 8 50 09 am

@ellisonbg
Copy link
Contributor Author

In all of these designs the first number is the lighter color of the bg and the second is the darker of the border.

@Carreau
Copy link
Member

Carreau commented Nov 25, 2015

I Prefer option B

@ellisonbg
Copy link
Contributor Author

I am fine with that and it is the current state of this PR if you want to merge...

@Carreau
Copy link
Member

Carreau commented Nov 25, 2015

+1 then, I'll let someone else decide.

@ellisonbg
Copy link
Contributor Author

@fperez or @minrk any preference on this visual design choice here?
Matthias and I are fine with B, but more than open to other thoughts.

On Wed, Nov 25, 2015 at 9:51 AM, Matthias Bussonnier <
[email protected]> wrote:

+1 then, I'll let someone else decide.


Reply to this email directly or view it on GitHub
#757 (comment).

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]

@minrk
Copy link
Member

minrk commented Nov 25, 2015

I, too, like B. I'll let @fperez hit the merge button.

@minrk minrk added this to the 4.1 milestone Nov 25, 2015
@ellisonbg
Copy link
Contributor Author

Yeah, I can see the light at the end of the (longer than expected) 4.1
tunnel.

On Wed, Nov 25, 2015 at 9:55 AM, Min RK [email protected] wrote:

I, too, like B. I'll let @fperez https://github.com/fperez hit the
merge button.


Reply to this email directly or view it on GitHub
#757 (comment).

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]

fperez added a commit that referenced this pull request Nov 25, 2015
Changing colors on find and replace matches.
@fperez fperez merged commit 7ce1dc5 into jupyter:master Nov 25, 2015
@fperez
Copy link
Member

fperez commented Nov 25, 2015

Merged! Thanks folks, one step closer :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants