-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing colors on find and replace matches. #757
Conversation
In all of these designs the first number is the lighter color of the bg and the second is the darker of the border. |
I Prefer option B |
I am fine with that and it is the current state of this PR if you want to merge... |
+1 then, I'll let someone else decide. |
@fperez or @minrk any preference on this visual design choice here? On Wed, Nov 25, 2015 at 9:51 AM, Matthias Bussonnier <
Brian E. Granger |
I, too, like B. I'll let @fperez hit the merge button. |
Yeah, I can see the light at the end of the (longer than expected) 4.1 On Wed, Nov 25, 2015 at 9:55 AM, Min RK [email protected] wrote:
Brian E. Granger |
Changing colors on find and replace matches.
Merged! Thanks folks, one step closer :) |
This is a follow up to #741 which lightens the colors of the find and replace matches and uses Material Design colors.