Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json tweak for long paths in conda package #19

Closed
wants to merge 1 commit into from

Conversation

pjaggi1
Copy link

@pjaggi1 pjaggi1 commented Jan 12, 2022

No description provided.

@hbcarlos
Copy link
Contributor

Hi @pjaggi1! Thanks for opening the PR!

Do you mind explaining a little more in detail why you want to change that?

Maybe the command jlpm run build:prod does exactly what you need, see https://github.com/QuantStack/jupyterlab-js-logs/blob/9950cf30e438c79565939da4b825e5f9bccd45a5/package.json#L37

@pjaggi1
Copy link
Author

pjaggi1 commented Jan 14, 2022

Hi @pjaggi1! Thanks for opening the PR!

Do you mind explaining a little more in detail why you want to change that?

Maybe the command jlpm run build:prod does exactly what you need, see

https://github.com/QuantStack/jupyterlab-js-logs/blob/9950cf30e438c79565939da4b825e5f9bccd45a5/package.json#L37

the current conda package has a couple of files like this: vendors-node_modules_css-loader_dist_runtime_api_js-node_modules_css-loader_dist_runtime_cssW-926fd9.aa45b7df615e3572a9b8.js.map
in it. we would like for those not to be there-they are causing us (long path) issues during our installation process.
I am not sure how those packages are built, but it looks like use the build (and not build:prod) command during the creation of the package. ultimately we would like a new package built-either changing the conda build to use build:prod or by keeping it as is and making this change.
would it be possible/better to change something here:
https://github.com/conda-forge/jupyterlab-js-logs-feedstock?

@hbcarlos
Copy link
Contributor

would it be possible/better to change something here

No, I think the problem is that we are building the extension in dev mode when publishing the package.
I need to investigate a little bit more the issue, but what you are doing on this PR is on the right path, this way when using the Jupyter Releaser, we will build in production.
If I recall correctly, the reason we are building in dev mode when publishing the package is that when I was adopting the Jupyter Releaser on this repo, I had some troubles building the extension with the release.

Let me investigate this a bit deeper.

@hbcarlos
Copy link
Contributor

@pjaggi1 This issue should be solved now with v0.2.6.
You can already using installing from pypi, for the conda package will take a few hours to be published.

Thanks again for opening the PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants