Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add support for the debugger flag in kernel info #201

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 18, 2019

Fixes #167.

TODO

  • Add debugger key to the interface
  • Check debugging is enabled before starting the service

@jtpio jtpio added this to the 0.1.0 milestone Nov 18, 2019
@jtpio jtpio marked this pull request as ready for review November 19, 2019 11:25
@JohanMabille
Copy link
Member

LGTM!

@jtpio
Copy link
Member Author

jtpio commented Nov 20, 2019

Whether we should show the debugger UI or not can be handled separately.

@jtpio
Copy link
Member Author

jtpio commented Nov 20, 2019

LGTM!

Taking this LGTM as approval :)

More to come in follow-up PRs.

@jtpio jtpio merged commit 84e0753 into jupyterlab:master Nov 20, 2019
@jtpio jtpio deleted the debugger-flag branch November 20, 2019 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for kernel debugging capabilities
2 participants