Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Use declarative style #140

Closed
wants to merge 3 commits into from
Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 14, 2019

Exact same functionality but done in declarative style which is more compact and easier to understand.

cclauss added 3 commits May 14, 2019 10:25
Exact same functionality but done in declarative style which is more compact and easier to understand.
@jeff5
Copy link
Member

jeff5 commented Aug 2, 2019

Thanks for this @cclauss . This has made our Travis tests comprehensible to me!

We normally commit by generating a patch, merging and testing locally, then pushing via hg.python.org/jython . I don't know how to test a CI change without pushing it, but I could see a bit of trial-and-error adjustment would be needed that would make a mess in the commit history.

Having done that on a branch of my own fork, I've now committed this PR as f1498dc, and my further adjustments as a345c91, currently being tested by Travis CI.

@jeff5
Copy link
Member

jeff5 commented Aug 2, 2019

It's so ,,, green.

@jeff5 jeff5 closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants