Ensure that disabled rules don't execute while running a sls remove #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug where if you have a disabled sync rule, like so:
And you try to run
sls remove
, if that bucket doesn't exist in the CloudFormation stack, s3-sync throws the following error:The problem is due to the fact that in the clear command, the process doesn't exit out early if the disabled flag is set. The fix is simply to add a guard clause in the
clear()
function, and exit if the enabled field is false. This means s3-sync won't try to retrieve the bucket, causing the above error.