Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that disabled rules don't execute while running a sls remove #124

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Ensure that disabled rules don't execute while running a sls remove #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30e9562
Ensure that disabled rules don't execute while removing
Jan 27, 2024
34a623b
Merge branch 'k1LoW:master' into allow-disabled-syncs
VirtualVirtuoso Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ custom:
- bucketName: my-other-site
localDir: path/to/other-site
deleteRemoved: true # optional, indicates whether sync deletes files no longer present in localDir. Defaults to 'true'
     acl: public-read # optional
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here is removing some non breaking spaces someone had introduced to the README

image

acl: public-read # optional
followSymlinks: true # optional
defaultContentType: text/html # optional
params: # optional
Expand Down
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,9 @@ class ServerlessS3Sync {
if (s.hasOwnProperty('bucketPrefix')) {
bucketPrefix = s.bucketPrefix;
}
if (s.hasOwnProperty('enabled') && s.enabled === false) {
return;
}
return this.getBucketName(s)
.then(bucketName => {
return new Promise((resolve) => {
Expand Down