Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactor eets blockchain test flow #237

Conversation

Mdaiki0730
Copy link
Contributor

@Mdaiki0730 Mdaiki0730 commented Jan 28, 2025

Proposed changes

  • Remove CreateContractWithCodeFormatInExecutionSpecTest (set genesis alloc correctly)
  • Remove TestBlockchain
  • Rename insertBlocksFromTx to insertBlocks
  • Rename decodeTx to decode
  • Remove TestHeader and, change it to btHeader
  • Use useEthGasPrice to calculate eth gas price (rename useEthGasPrice to calculateEthGasPrice)
  • Enable parallel execution of tests
  • Comment (config etc...)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Mdaiki0730 Mdaiki0730 force-pushed the feat/eets-refactor-test-flow branch 3 times, most recently from 5445237 to b735ac5 Compare January 28, 2025 09:19
tests/block_test_util.go Outdated Show resolved Hide resolved
@Mdaiki0730 Mdaiki0730 force-pushed the feat/eets-refactor-test-flow branch from b735ac5 to 3adc01d Compare January 28, 2025 10:21
@Mdaiki0730 Mdaiki0730 force-pushed the feat/eets-refactor-test-flow branch from 3adc01d to b05c85c Compare January 28, 2025 10:32
@Mdaiki0730 Mdaiki0730 marked this pull request as ready for review January 28, 2025 10:33
Copy link
Contributor

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mdaiki0730 Mdaiki0730 merged commit 621c6f2 into kaiachain:feat/eets-blockchain-test Jan 28, 2025
9 checks passed
@Mdaiki0730 Mdaiki0730 deleted the feat/eets-refactor-test-flow branch January 28, 2025 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants