Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI/CD with GitHub Actions #249

Merged
merged 13 commits into from
Mar 4, 2022
Merged

Add CI/CD with GitHub Actions #249

merged 13 commits into from
Mar 4, 2022

Conversation

jginsburgn
Copy link
Member

@jginsburgn jginsburgn commented Feb 15, 2022 •
edited
Loading

Also, migrate from Grunt to Semantic Release and do a general cleanup.

Resolves #242 #243

@jginsburgn jginsburgn requested review from mtrea and devoto13 February 15, 2022 07:59
devoto13
devoto13 previously approved these changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Couple of non-blocking nits to consider.

.github/workflows/test.yml Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jginsburgn jginsburgn mentioned this pull request Mar 3, 2022
Open
This was referenced Mar 3, 2022
Closed
Open
@jginsburgn jginsburgn requested review from devoto13 and removed request for devoto13 and mtrea March 3, 2022 21:39
devoto13
devoto13 previously approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore seems to be allowed with the latest changes though...

@jginsburgn
Copy link
Member Author

chore seems to be allowed with the latest changes though...

Done! Sorry for the delay.

@jginsburgn
Copy link
Member Author

BTW, let me also fix the commit types

Jonathan Ginsburg added 12 commits March 3, 2022 17:59
build: ignore macOS meta files
deac925
build: track package-lock.json
22599c0
build: use npm instead of Grunt
0c943ad 
Except for updating contributors, which remains in Grunt.

#243
build: remove Travis
98daf4e
ci: add the "Test" GitHub Actions workflow
6c2cb27
ci: add commitlint
6e36823
ci: add the "Release" GitHub Actions workflow
b43e5a2 
Also:

* Remove the "pretest" npm script as it is explicitly called in the "Test"
GitHub Actions workflow.
* Allow for the "chore" commit type as it is used by the grunt "contributors"
task.
build: add the update-contributors tool
8a7c4be
build: remove unnecessary "set up Chrome" step in "Test" workflow
17294ad
fix: artificially trigger a release
e68ed5a 
This will ensure that the recent CI/CD Release workflow with GitHub Actions is
working properly.
ci: conduct unit tests first
de5adf7
build: disallow chore type commits
948fe84 
See karma-runner/karma#3772
@jginsburgn jginsburgn requested review from devoto13 and mtrea March 4, 2022 00:01
mtrea
mtrea requested changes Mar 4, 2022
View reviewed changes
Copy link

@mtrea mtrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding some documentation along with this. I'm sure GitHub has their own "Actions" doc, but consider whether there's anything Karma-specific that contributors might need to know (copy-pastable command to run tests, where to view results, how to rerun tests, etc).

@jginsburgn
Copy link
Member Author

Please consider adding some documentation along with this. I'm sure GitHub has their own "Actions" doc, but consider whether there's anything Karma-specific that contributors might need to know (copy-pastable command to run tests, where to view results, how to rerun tests, etc).

@mtrea please check the latest commit :)

@jginsburgn jginsburgn requested a review from mtrea March 4, 2022 00:39
mtrea
mtrea approved these changes Mar 4, 2022
View reviewed changes
Copy link

@mtrea mtrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookş ġṑod to me

@jginsburgn jginsburgn merged commit 5400b23 into master Mar 4, 2022
@jginsburgn jginsburgn deleted the ci-cd branch March 4, 2022 22:56
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jginsburgn jginsburgn mentioned this pull request Aug 27, 2022
Merged
@wswebcreation wswebcreation mentioned this pull request Aug 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrea mtrea mtrea approved these changes

@devoto13 devoto13 devoto13 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Up CI/CD with GitHub Actions
4 participants
@jginsburgn @karmarunnerbot @devoto13 @mtrea