Bump saucelabs dep to 6.2.2

[taymoork2]

Unsure if this will fix instability issues we're seeing on our end, but at least this will get the SC Tunnel to the latest version
Not seeing any breaking changes that need to addressed from bumping, unless we bump to v7 where node v10 support will be dropped

[seanpoulter]

I'm also here investigating instability issues. Would folks be willing to cut a new release with [email protected] and a major version that drops support for Node.js v10 and uses [email protected]? Let me know, I'm willing to drive it forward.

[seanpoulter]

With package.json:

  "devDependencies": {
    …
    "saucelabs": "^7.1.3",
    …
  },
  "overrides": {
    "karma-sauce-launcher": {
      "saucelabs": "$saucelabs"
    }
  },

Then [email protected] seems to worked this far:

[Havunen]

Who is maintaining this package, it would be good to get saucelabs updated and new version of karma-sauce-launcher published to NPM @vojtajina @rcebulko @dignifiedquire @johnjbarton

[seanpoulter]

What motivated this change? The rest of the changes appear to be formatting.

[taymoork2]

This is a result of going from v4 to v6, it switched from an Array of Objects to an Array of strings
I believe it fails otherwise

https://github.com/saucelabs/node-saucelabs/blob/main/README.md?plain=1#L108=

[taymoork2]

I think i just ran prettier through it hence the formatting changes

[lo1tuma]

Is there anything I can help with, to get this change merged?

[seanpoulter]

I'm available to help drive this forwards but I'm not a maintainer. If it was up to me as a reviewer I'd suggest we split the formatting from the dependency update so it is very low effort to approve.

I'd also suggest that we cut a release for saucelabs v6.x and v7.x. I'm happy to make those PRs today if anyone's available. 🙏

[lo1tuma]

@jginsburgn would you be able to help us with this topic?

[lo1tuma]

ping @wswebcreation

[Havunen]

It would make more sense to bump saucelabs to latest version IMO

[taymoork2]

It would make more sense to bump saucelabs to latest version IMO

@Havunen the reason I didn't bump to v7 was because it dropped support for node v10 and that's technically a breaking change, which is on the maintainers to address

[taymoork2]

@lo1tuma if you need a slightly more modern solution, it might be best to switch to @web/test-runner or just use builtin-browsers on your CI images
We (at Webex) tried @web/test-runner, however both sauce and browserstack plugins put the tests in an iframe and that wasnt working with WebRTC related tests, so we switched to the builtin browsers provided by CircleCI's node image

The alternative to all that is to use the overrides property in the newer version of npm or resolutions in yarn, as mentioned above

[jginsburgn]

@jginsburgn would you be able to help us with this topic?

Sorry for my delay in answering. I am no longer a good primary PoC for the Karma projects. It's better to tag @karma-runner/google-web-test-team directly!

[taymoork2]

@wswebcreation can we can get your review on this?

[Havunen]

Maybe we should create a new launcher with latest version of saucelabs setup? This project seems abandoned

[seanpoulter]

Who do we talk to so we can check if we can get a fork in saucelabs/ instead of karma-runner/?

[barrtender]

Hey everyone, sorry for the slow reply here.

I'm on that @karma-runner/google-web-test-team that @jginsburgn mentioned and have been trying to ramp up on the various Karma plugins that we own and what their maintenance plans are.

Unfortunately for plugins like this where we don't use them internally we aren't nearly as plugged in to the changes that need to be made to keep them up to date. It would be best if someone that actually used it would be able to take ownership of the plugin so that it can get the care it deserves.

If someone would like to volunteer for that I can change the README in this repo to point to your fork. This is a project that is licensed with the MIT license so forking is totally approved.

Let me know if there's any other questions. I'm fairly new on the team so like I said I'm still ramping up on things but if I can't answer them myself I should be able to find someone that can.

Thanks, and sorry again for the slow reply.
@barrtender

[taymoork2]

@barrtender thanks for the reply

I think the only maintenace that needs to be done on this repo is just making the sure the saucelabs dependency is up to date. So maintenace should be relatively low effort in that regard, and I'm guessing dependabot should be able to handle it going forward.
The only thing maintainers would need to address when upgrading Saucelabs to the latest version, it drops support for Node v10, so a Breaking Change will need to be addressed
If you'd still want the plugin forked, I'd suggest having someone from Saucelabs take over maintance.

[wswebcreation]

Merged it, thanks! Now need to see how to release a new version

[wswebcreation]

Hi @barrtender

I'm trying to release a new version but this was set up by @rcebulko in the past. It would do an automatic release based on commit messages with the https://github.com/karmarunnerbot, see for example #243.
This is not working anymore. Can we have a conversation about how to resolve the releasing strategy for this plugin?

Grtz

Wim Selles @wswebcreation

[Havunen]

Thanks a lot for merging this, I'm looking forward for the new version!
Now that you are at it, is it possible to also release v7 saucelabs?

but at least this will get the SC Tunnel to the latest version
Not seeing any breaking changes that need to addressed from bumping, unless we bump to v7 where node v10 support will be dropped

If NodeJs support is seeing as an issue, then maybe this plugin could also make a major version bump to indicate the breaking change and old nodejs users can stick with old version.

[wswebcreation]

Hi @Havunen

thanks, but I can’t release, it seems that the pipeline is broken. I need help from the karma team to move this of Travis and run this from GHA

Then I can create a new release and in the end also release V4 which will drop support for NodeJs 10

[jginsburgn]

Hi @Havunen

thanks, but I can’t release, it seems that the pipeline is broken. I need help from the karma team to move this of Travis and run this from GHA

Then I can create a new release and in the end also release V4 which will drop support for NodeJs 10

@wswebcreation if you (or anyone) are willing to create a PR like karma-runner/karma-chrome-launcher#249, I can take a look and approve to get GHA working and this fix released.

[taymoork2]

@jginsburgn does it need to be exact copy of chrome-launcher or just converting the existing travis config to GHA?

[taymoork2]

@jginsburgn this seems to be the bear minimum to convert the existing travis yaml to a github action

1. Checkout code
2. Install Node
3. Install yarn
4. install deps
5. run samples command
6. build
7. semantic release

https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/ci-configurations/github-actions.md#node-project-configuration

[wswebcreation]

@jginsburgn

Thanks, I can take a look at it this week

[wswebcreation]

@jginsburgn

I've created #274