Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump saucelabs dep to 6.2.2 #256

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Bump saucelabs dep to 6.2.2 #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"author": "Vojta Jina <[email protected]>",
"dependencies": {
"global-agent": "^2.1.12",
"saucelabs": "^4.6.3",
"saucelabs": "6.2.2",
"webdriverio": "^6.7.0"
},
"license": "MIT",
Expand Down
12 changes: 2 additions & 10 deletions src/launcher/launcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,8 @@ export function SaucelabsLauncher(args,
sessionId,
{
files: [
{
filename: 'log.json',
data: results,
},
{
filename: 'old-log.json',
data: {
someLog: oldLogs
}
},
'log.json',
'old-log.json'
Comment on lines +90 to +91
Copy link

@seanpoulter seanpoulter May 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What motivated this change? The rest of the changes appear to be formatting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a result of going from v4 to v6, it switched from an Array of Objects to an Array of strings
I believe it fails otherwise

https://github.com/saucelabs/node-saucelabs/blob/main/README.md?plain=1#L108=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i just ran prettier through it hence the formatting changes

],
},
);
Expand Down
Loading