Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #6131: Bump Go version to 1.22.12 #6132

Conversation

sachinparihar
Copy link
Contributor

@sachinparihar sachinparihar commented Feb 18, 2025

Cherry pick of #6131 on release-1.12.
#6131: Bump Go version to 1.22.12
For details on the cherry pick process, see the cherry pick requests page.

Karmada now built with Golang v1.22.12.

Signed-off-by: sachinparihar <[email protected]>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2025
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@RainbowMango
Copy link
Member

@XiShanYongYe-Chang Can you help to take a look at the failing unit tests? Note that this PR is for release-1.12, we need to check if the same issue exists on the master.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a flake error that has been recorded a long time ago: #5926, and after some fixes, there is no such error on the master branch, maybe we can synchronize the #5936 change to the release-1.12 branch.

Current pr we can rerun ut.
/retest

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.51%. Comparing base (8eb2774) to head (7c46ad8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #6132      +/-   ##
================================================
- Coverage         46.53%   46.51%   -0.03%     
================================================
  Files               664      664              
  Lines             54810    54810              
================================================
- Hits              25507    25495      -12     
- Misses            27676    27685       +9     
- Partials           1627     1630       +3     
Flag Coverage Δ
unittests 46.51% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot karmada-bot merged commit e56bc63 into karmada-io:release-1.12 Feb 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants