Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.22.12 #6131

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

sachinparihar
Copy link
Contributor

@sachinparihar sachinparihar commented Feb 18, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR bump Golang to the latest v1.22 release.

Which issue(s) this PR fixes:

Part of #6127

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada now built with Golang v1.22.12.

Signed-off-by: sachinparihar <[email protected]>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 18, 2025
@karmada-bot
Copy link
Collaborator

Welcome @sachinparihar! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.10%. Comparing base (c5d640c) to head (61c452d).
Report is 16 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6131      +/-   ##
==========================================
- Coverage   48.12%   48.10%   -0.02%     
==========================================
  Files         668      668              
  Lines       55258    55291      +33     
==========================================
+ Hits        26591    26597       +6     
- Misses      26935    26956      +21     
- Partials     1732     1738       +6     
Flag Coverage Δ
unittests 48.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @sachinparihar ! Looks good to me, I will take care of the failing fake test.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@RainbowMango
Copy link
Member

Thanks to @y1hao as well, it was you who made the Go version upgrade so simple.

@sachinparihar
Copy link
Contributor Author

/lgtm

Thank you @sachinparihar ! Looks good to me, I will take care of the failing fake test.

Thank you @RainbowMango ! I appreciate your review and support. Excited to contribute more!

@RainbowMango
Copy link
Member

/retest
fake test:

 [FAILED] Unexpected error:
      <*errors.StatusError | 0xc000a66640>: 
      etcdserver: request timed out
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "etcdserver: request timed out",
              Reason: "",
              Details: nil,
              Code: 500,
          },
      }
  occurred
  In [DeferCleanup (Each)] at: /home/runner/work/karmada/karmada/test/e2e/framework/propagationpolicy.go:46 @ 02/18/25 06:07:45.437

@RainbowMango RainbowMango added this to the v1.13 milestone Feb 18, 2025
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@karmada-bot karmada-bot merged commit f555413 into karmada-io:master Feb 18, 2025
21 checks passed
karmada-bot added a commit that referenced this pull request Feb 19, 2025
…#6131-upstream-release-1.12

Automated cherry pick of #6131: Bump Go version to 1.22.12
karmada-bot added a commit that referenced this pull request Feb 20, 2025
…#6131-upstream-release-1.11

Automated cherry pick of #6131: Bump Go version to 1.22.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants