-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go version to 1.22.12 #6131
Conversation
Signed-off-by: sachinparihar <[email protected]>
Welcome @sachinparihar! It looks like this is your first PR to karmada-io/karmada 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6131 +/- ##
==========================================
- Coverage 48.12% 48.10% -0.02%
==========================================
Files 668 668
Lines 55258 55291 +33
==========================================
+ Hits 26591 26597 +6
- Misses 26935 26956 +21
- Partials 1732 1738 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you @sachinparihar ! Looks good to me, I will take care of the failing fake test.
Thanks to @y1hao as well, it was you who made the Go version upgrade so simple. |
Thank you @RainbowMango ! I appreciate your review and support. Excited to contribute more! |
/retest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#6131-upstream-release-1.12 Automated cherry pick of #6131: Bump Go version to 1.22.12
…#6131-upstream-release-1.11 Automated cherry pick of #6131: Bump Go version to 1.22.12
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR bump Golang to the latest v1.22 release.
Which issue(s) this PR fixes:
Part of #6127
Special notes for your reviewer:
Does this PR introduce a user-facing change?: