Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qml and xml files when downloading a layer in zip and geotiff formats #540

Merged

Conversation

boney-bun
Copy link

@boney-bun boney-bun commented Dec 17, 2018

fix #539

@boney-bun
Copy link
Author

the PR in actions:
when downloading zip file:
fix-geonode-539

when downloading geotiff:
fix-geonode-539-2

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #540 into 2.8.x-qgis_server will increase coverage by 0.03%.
The diff coverage is 90.9%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           2.8.x-qgis_server     #540      +/-   ##
=====================================================
+ Coverage              41.52%   41.55%   +0.03%     
=====================================================
  Files                    412      412              
  Lines                  29670    29688      +18     
  Branches                3752     3754       +2     
=====================================================
+ Hits                   12319    12336      +17     
  Misses                 16589    16589              
- Partials                 762      763       +1
Impacted Files Coverage Δ
geonode/qgis_server/tests/test_views.py 99.28% <100%> (ø) ⬆️
geonode/qgis_server/views.py 61.67% <90%> (+1.25%) ⬆️
geonode/qgis_server/models.py 84.14% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba48295...8722855. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #540 into 2.8.x-qgis_server will decrease coverage by 7.97%.
The diff coverage is 0%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           2.8.x-qgis_server     #540      +/-   ##
=====================================================
- Coverage              41.52%   33.54%   -7.98%     
=====================================================
  Files                    412      412              
  Lines                  29670    29687      +17     
  Branches                3752     3753       +1     
=====================================================
- Hits                   12319     9958    -2361     
- Misses                 16589    19100    +2511     
+ Partials                 762      629     -133
Impacted Files Coverage Δ
geonode/qgis_server/views.py 0% <0%> (-60.42%) ⬇️
geonode/qgis_server/context_processors.py 0% <0%> (-100%) ⬇️
geonode/qgis_server/urls.py 0% <0%> (-100%) ⬇️
...ent/commands/delete_orphaned_qgis_server_layers.py 0% <0%> (-100%) ⬇️
geonode/qgis_server/tests/test_qgis_settings.py 0% <0%> (-100%) ⬇️
geonode/qgis_server/tests/test_xml_utilities.py 0% <0%> (-100%) ⬇️
.../qgis_server/migrations/0003_auto_20170727_0509.py 0% <0%> (-100%) ⬇️
.../qgis_server/migrations/0005_auto_20170823_0341.py 0% <0%> (-100%) ⬇️
geonode/qgis_server/migrations/0001_initial.py 0% <0%> (-100%) ⬇️
geonode/qgis_server/admin/__init__.py 0% <0%> (-100%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba48295...9234bde. Read the comment docs.

# The zip compressor
zf = zipfile.ZipFile(s, "w")


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 line is enough IMO 😅

Copy link

@myarjunar myarjunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@boney-bun
Copy link
Author

thanks @myarjunar
i'm going to merge this PR to see it on the testing

@boney-bun boney-bun merged commit 8c6ba48 into kartoza:2.8.x-qgis_server Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants