-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add qml and xml files when downloading a layer in zip and geotiff formats #540
add qml and xml files when downloading a layer in zip and geotiff formats #540
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.8.x-qgis_server #540 +/- ##
=====================================================
+ Coverage 41.52% 41.55% +0.03%
=====================================================
Files 412 412
Lines 29670 29688 +18
Branches 3752 3754 +2
=====================================================
+ Hits 12319 12336 +17
Misses 16589 16589
- Partials 762 763 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 2.8.x-qgis_server #540 +/- ##
=====================================================
- Coverage 41.52% 33.54% -7.98%
=====================================================
Files 412 412
Lines 29670 29687 +17
Branches 3752 3753 +1
=====================================================
- Hits 12319 9958 -2361
- Misses 16589 19100 +2511
+ Partials 762 629 -133
Continue to review full report at Codecov.
|
geonode/qgis_server/views.py
Outdated
# The zip compressor | ||
zf = zipfile.ZipFile(s, "w") | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 line is enough IMO 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
thanks @myarjunar |
fix #539