Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninitialized use of py::object #226

Closed
eirrgang opened this issue Jun 25, 2019 · 0 comments
Closed

uninitialized use of py::object #226

eirrgang opened this issue Jun 25, 2019 · 0 comments
Assignees
Labels
bug gmxapi pertains to this repository and the Python module support sample_restraint pertains specifically to kassonlab/sample_restraint

Comments

@eirrgang
Copy link
Collaborator

I think py::object is initialized with a nullptr member pointer, but this is not the same thing as being a reference to None. In any case, both the main python package and the sample_restraint code need to be checked and updated to make sure that we don't try to access attributes of uninitialized py::objects because evidence suggests it could cause segmentation faults rather than raising exceptions.

Relates to #221 and #188

If such checks resolve issues with test cases built on #224 then I think we can call this a bug fix and not necessitate an API version bump to accompany #221

@eirrgang eirrgang added bug sample_restraint pertains specifically to kassonlab/sample_restraint gmxapi pertains to this repository and the Python module support labels Jun 25, 2019
@eirrgang eirrgang self-assigned this Jun 25, 2019
@jmhays jmhays mentioned this issue Jun 25, 2019
@eirrgang eirrgang closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gmxapi pertains to this repository and the Python module support sample_restraint pertains specifically to kassonlab/sample_restraint
Projects
None yet
Development

No branches or pull requests

1 participant