Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmxapi 221 #224

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Gmxapi 221 #224

merged 3 commits into from
Jun 25, 2019

Conversation

eirrgang
Copy link
Collaborator

Fixes #221

@eirrgang eirrgang added the gmxapi pertains to this repository and the Python module support label Jun 21, 2019
@eirrgang eirrgang requested a review from jmhays June 21, 2019 11:11
@eirrgang eirrgang self-assigned this Jun 21, 2019
@eirrgang eirrgang force-pushed the gmxapi-221 branch 2 times, most recently from f90e8a3 to 44f6342 Compare June 21, 2019 14:00
Copy link
Contributor

@jmhays jmhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to run a short simulation where I send six different plugins (i.e., each plugin is restraining a different pair of atoms) to six different ensemble members. I am attaching an example pytest output from my latest attempt. You can see that gmxapi recognizes six different restraints and six different tprs. However, I get a little bit lost in the Error output after that...
pytest.txt
You can also see my repo here

@jmhays
Copy link
Contributor

jmhays commented Jun 21, 2019

It appears that the Travis builds are failing with this same issue as described above.

gmxapi-pluginarray-fail

This is a screenshot from my Travis builds, but it should be the same error as in vanilla gmxapi because I have to build gmxapi first before running my own tests.

@eirrgang eirrgang force-pushed the gmxapi-221 branch 4 times, most recently from 05fcafb to 9630656 Compare June 24, 2019 09:46
eirrgang added 3 commits June 24, 2019 12:47
Update host environment in .travis.yml

Fixes kassonlab#222
* Require WorkElement.name to be str type.
* Use str in WorkElement.depends
* Consistently use native str for keys in dict of WorkElement.
If a tuple or list of dependencies is added
to a work element, map the context_rank to
the list item when setting up the graph builders
in Context.__enter__

Fixes kassonlab#221
@eirrgang
Copy link
Collaborator Author

Okay, I had a little trouble getting things to work in both Python 2 and 3, but I think I got it now. Please give it a try. If it works, feel free to merge.

@jmhays
Copy link
Contributor

jmhays commented Jun 25, 2019

Ok, it looks like the fix for my issues are actually in #226, so I'm going to merge this.

@jmhays jmhays merged commit beaea7c into kassonlab:devel Jun 25, 2019
@eirrgang eirrgang deleted the gmxapi-221 branch June 27, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gmxapi pertains to this repository and the Python module support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants