Check for uninitialized py::object #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirrgang
force-pushed
the
gmxapi-226
branch
3 times, most recently
from
af0b9cb to
6e48bb1
Compare
jmhays
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build() function that instantiates the potential and publishes it to the MD subscriber did not check whether there was an actual subscriber object to publish to. A
pybind11::objectis initialized with a nullptr member rather than None or a reference-counted Python object, so this sort of access causes a segmentation fault instead of a Python error. We could consider initializingpy::objectmembers toNone, but a simple check suffices for now. In the longer run, we are reworking this protocol and one goal should be to avoid holding Python references at all.I also checked the kassonlab/gmxapi sources and don't see any similarly unsafe uses of
py::object, so I think this PR resolves kassonlab/gmxapi#226