Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refine some code and comments in the sema crate. #12

Merged
merged 1 commit into from
May 19, 2022
Merged

refactor: refine some code and comments in the sema crate. #12

merged 1 commit into from
May 19, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 16, 2022

Purpose:

  1. refactor some documents on the schema type in the sema crate.

@Peefy Peefy requested review from chai2010 and zong-zhe May 16, 2022 12:59
@Peefy Peefy added the documentation Improvements or additions to documentation label May 16, 2022
chai2010
chai2010 reviewed May 17, 2022
View reviewed changes
kclvm/sema/src/ty/mod.rs Outdated Show resolved Hide resolved
@Peefy Peefy force-pushed the dev/peefy/sema_minor_refactor branch from 81dd852 to 3ae2c42 Compare May 17, 2022 09:39
@Peefy Peefy requested a review from ldxdl May 17, 2022 10:04
ldxdl
ldxdl reviewed May 17, 2022
View reviewed changes
kclvm/sema/src/ty/mod.rs Outdated Show resolved Hide resolved
@Peefy Peefy force-pushed the dev/peefy/sema_minor_refactor branch from 3ae2c42 to b0e4a6f Compare May 17, 2022 13:57
@chai2010 chai2010 self-requested a review May 18, 2022 04:09
chai2010
chai2010 approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldxdl
ldxdl approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@ldxdl ldxdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Peefy Peefy merged commit 26ccc7f into main May 19, 2022
@Peefy Peefy deleted the dev/peefy/sema_minor_refactor branch May 22, 2022 07:48
@Peefy Peefy mentioned this pull request May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldxdl ldxdl ldxdl approved these changes

@chai2010 chai2010 chai2010 approved these changes

@zong-zhe zong-zhe Awaiting requested review from zong-zhe

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Peefy @chai2010 @ldxdl