feat: Support extra kubernetes manifests #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
reviewed
Mar 7, 2023
tomkerkhove
reviewed
Mar 8, 2023
fboula
force-pushed
the
feat/extra-manifests
branch
2 times, most recently
from
225db39 to
fd06f3a
Compare
tomkerkhove
reviewed
Mar 13, 2023
|
Could you check the e2e tests too? It seems that the extra manifests are applied before the others and that's why they are failing (because ClusterTriggerAuthentication isn't registered yet) |
fboula
force-pushed
the
feat/extra-manifests
branch
2 times, most recently
from
b0f9633 to
767b9e3
Compare
fboula
force-pushed
the
feat/extra-manifests
branch
from
767b9e3 to
833316a
Compare
JorTurFer
reviewed
Apr 5, 2023
JorTurFer
reviewed
Apr 5, 2023
|
I also need this feature to be able to deploy NetworkPolicies :-) Is there something I could assist? |
|
@fboula , any update ? |
Signed-off-by: Florian Boulanger <[email protected]>
Signed-off-by: Florian Boulanger <[email protected]>
fboula
force-pushed
the
feat/extra-manifests
branch
4 times, most recently
from
67ec8a1 to
23a8470
Compare
mkilchhofer
reviewed
May 11, 2023
fboula
force-pushed
the
feat/extra-manifests
branch
from
23a8470 to
e8904b2
Compare
mkilchhofer
reviewed
May 11, 2023
Signed-off-by: Florian Boulanger <[email protected]>
fboula
force-pushed
the
feat/extra-manifests
branch
4 times, most recently
from
873b427 to
dd0bf70
Compare
Signed-off-by: Florian Boulanger <[email protected]>
fboula
force-pushed
the
feat/extra-manifests
branch
from
dd0bf70 to
04ad7ef
Compare
Closed
|
@JorTurFer I added a post-install hook on the test case. It looks better, thanks for the hint. |
|
@JorTurFer any updates ? |
JorTurFer
approved these changes
May 26, 2023
|
Thanks for the improvement ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for extra kubernetes manifest creation. Fixes #394
Checklist