Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support extra kubernetes manifests #395

Merged
merged 5 commits into from
May 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/ci-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,17 @@ jobs:
certManager:
enabled: ${{ matrix.enableCertManager }}
generateCA: true
extraObjects:
- apiVersion: keda.sh/v1alpha1
kind: ClusterTriggerAuthentication
metadata:
name: aws-credentials
namespace: keda
annotations:
helm.sh/hook: post-install
spec:
podIdentity:
provider: aws-eks
EOF

- name: Install deps
Expand Down
2 changes: 1 addition & 1 deletion keda/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ their default values.
| `certificates.certManager.generateCA` | Generates a self-signed CA with Cert-manager | `true` |
| `certificates.certManager.caSecretName` | Secret name where the CA is stored (generatedby cert-manager or user given) | `kedaorg-ca` |
| `certificates.certManager.secretTemplate` | [Labels or annotations to add to the secret generated](https://cert-manager.io/docs/usage/certificate/#creating-certificate-resources) by cert-manager | `{}` |

| `extraObjects` | Array of extra K8s manifests to deploy | `[]`|
fboula marked this conversation as resolved.
Show resolved Hide resolved

Specify each parameter using the `--set key=value[,key=value]` argument to
`helm install`. For example:
Expand Down
4 changes: 4 additions & 0 deletions keda/templates/99-extra-manifests.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{{ range .Values.extraObjects }}
---
{{ tpl (toYaml .) $ }}
{{ end }}
11 changes: 11 additions & 0 deletions keda/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -472,3 +472,14 @@ permissions:
operator:
restrict:
secret: false

# Array of extra K8s manifests to deploy
extraObjects: []
# - apiVersion: keda.sh/v1alpha1
# kind: ClusterTriggerAuthentication
# metadata:
# name: aws-credentials
# namespace: keda
# spec:
# podIdentity:
# provider: aws-eks