Added Azure Log Analytics scaler documentation #244

spoplavskiy · 2020-09-04T07:05:56Z

Signed-off-by: Sergiy Poplavskyi [email protected]

Relates to kedacore/keda#1061

tomkerkhove

Added a bunch of first comments but high-level looks fine, thanks!

content/docs/2.0/scalers/azure-log-analytics.md

tomkerkhove · 2020-09-04T07:09:24Z

content/docs/2.0/scalers/azure-log-analytics.md

+      clientID: "04b4ca0a-82b1-4c0a-bbbb-7946442e805b"
+      clientSecret: "vU6UtUXls6RNXxv~l6NRi1V8J1fnk5Q-ce"
+      workspaceID: "81963c40-af2e-47cd-8e72-3002e08aa2af"
+      query: "let AppName = \"web\";\r\nlet ClusterName = \"demo-cluster\";\r\nlet AvgDuration = ago(10m);\r\nlet ThresholdCoefficient = 0.8;\r\nPerf\r\n| where InstanceName contains AppName\r\n| where InstanceName contains ClusterName\r\n| where CounterName == \"cpuUsageNanoCores\"\r\n| where TimeGenerated > AvgDuration\r\n| extend AppName = substring(InstanceName, indexof((InstanceName), \"/\", 0, -1, 10) + 1)\r\n| summarize MetricValue=round(avg(CounterValue)) by CounterName, AppName\r\n| join (Perf \r\n        | where InstanceName contains AppName\r\n        | where InstanceName contains ClusterName\r\n        | where CounterName == \"cpuLimitNanoCores\"\r\n        | where TimeGenerated > AvgDuration\r\n        | extend AppName = substring(InstanceName, indexof((InstanceName), \"/\", 0, -1, 10) + 1)\r\n        | summarize arg_max(TimeGenerated, *) by AppName, CounterName\r\n        | project Limit = CounterValue, TimeGenerated, CounterPath, AppName)\r\n        on AppName\r\n| project MetricValue, Threshold = Limit * ThresholdCoefficient"


I'm wondering - Do we use in-line queries, use config map or mount them on the scaled workload?

Thoughts @zroubalik @ahmelsayed ?

@tomkerkhove , I used Prometheus Scaler as reference: https://keda.sh/docs/1.5/scalers/prometheus/

Makes sense but in this case, they are a bit longer. It's ok for me but just want to verify with the others.

You can define a multi-line string in yaml using

... query: | let AppName = "web"; let ClusterName = "demo-cluster"; let AvgDuration = ago(10m); let ThresholdCoefficient = 0.8; Perf | where InstanceName contains AppName | where InstanceName contains ClusterName | where CounterName == "cpuUsageNanoCores" | where TimeGenerated > AvgDuration | extend AppName = substring(InstanceName, indexof((InstanceName), "/", 0, -1, 10) + 1) | summarize MetricValue=round(avg(CounterValue)) by CounterName, AppName | join (Perf | where InstanceName contains AppName | where InstanceName contains ClusterName | where CounterName == "cpuLimitNanoCores" | where TimeGenerated > AvgDuration | extend AppName = substring(InstanceName, indexof((InstanceName), "/", 0, -1, 10) + 1) | summarize arg_max(TimeGenerated, *) by AppName, CounterName | project Limit = CounterValue, TimeGenerated, CounterPath, AppName) on AppName | project MetricValue, Threshold = Limit * ThresholdCoefficient

which might make it look a bit more readable.

Love the suggestion!

content/docs/2.0/scalers/azure-log-analytics.md

tomkerkhove

LGTM, but allowing others to comment as well.

content/docs/2.0/scalers/azure-log-analytics.md

tomkerkhove · 2020-09-07T05:27:57Z

content/docs/2.0/scalers/azure-log-analytics.md

+      clientID: "04b4ca0a-82b1-4c0a-bbbb-7946442e805b"
+      clientSecret: "vU6UtUXls6RNXxv~l6NRi1V8J1fnk5Q-ce"
+      workspaceID: "81963c40-af2e-47cd-8e72-3002e08aa2af"
+      query: "let AppName = \"web\";\r\nlet ClusterName = \"demo-cluster\";\r\nlet AvgDuration = ago(10m);\r\nlet ThresholdCoefficient = 0.8;\r\nPerf\r\n| where InstanceName contains AppName\r\n| where InstanceName contains ClusterName\r\n| where CounterName == \"cpuUsageNanoCores\"\r\n| where TimeGenerated > AvgDuration\r\n| extend AppName = substring(InstanceName, indexof((InstanceName), \"/\", 0, -1, 10) + 1)\r\n| summarize MetricValue=round(avg(CounterValue)) by CounterName, AppName\r\n| join (Perf \r\n        | where InstanceName contains AppName\r\n        | where InstanceName contains ClusterName\r\n        | where CounterName == \"cpuLimitNanoCores\"\r\n        | where TimeGenerated > AvgDuration\r\n        | extend AppName = substring(InstanceName, indexof((InstanceName), \"/\", 0, -1, 10) + 1)\r\n        | summarize arg_max(TimeGenerated, *) by AppName, CounterName\r\n        | project Limit = CounterValue, TimeGenerated, CounterPath, AppName)\r\n        on AppName\r\n| project MetricValue, Threshold = Limit * ThresholdCoefficient"


Makes sense but in this case, they are a bit longer. It's ok for me but just want to verify with the others.

tomkerkhove · 2020-09-07T05:28:42Z

LGTM, but want your input on some topics @zroubalik @ahmelsayed .

tomkerkhove · 2020-09-07T06:34:07Z

@spoplavskiy feel free to add a note to https://github.com/kedacore/keda-docs/blob/master/content/blog/keda-2.0-beta.md.draft#L15 with your new scaler please? Thanks!

spoplavskiy · 2020-09-07T11:06:01Z

@spoplavskiy feel free to add a note to https://github.com/kedacore/keda-docs/blob/master/content/blog/keda-2.0-beta.md.draft#L15 with your new scaler please? Thanks!

@tomkerkhove , thanks for pointing. Added in last commit.

zroubalik · 2020-09-10T08:24:48Z

@spoplavskiy one last thing, DCO please :)

tomkerkhove · 2020-09-10T08:26:30Z

And this great suggestion: https://github.com/kedacore/keda-docs/pull/244/files#r486117830

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

* Provide 404 Not Found page Signed-off-by: Tom Kerkhove <[email protected]> * Provide better 404 page Signed-off-by: Tom Kerkhove <[email protected]> * Missing / Signed-off-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Tsuyoshi Ushio <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Danny Seymour <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Sergiy Poplavskyi <[email protected]>

spoplavskiy · 2020-09-10T09:20:31Z

And this great suggestion: https://github.com/kedacore/keda-docs/pull/244/files#r486117830

@tomkerkhove, Changed query to multiline in last commit

spoplavskiy · 2020-09-10T09:30:36Z

@tomkerkhove, @zroubalik It looks like command, suggested by DCO tool to sign-off all my commits produced unexpected result :) It it now hard to revert and find in git log all my commits, as many of them was just applying inline suggections.

What if we finish reviewing this PR, and I will close this and open a new one by forking last version and applying my changes in single signed commit? Is that OK?

…237)" This reverts commit 67cb894.

Signed-off-by: Sergiy Poplavskyi <[email protected]>

…237)" This reverts commit 67cb894. Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

…screenshot Signed-off-by: Sergiy Poplavskyi <[email protected]>

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Signed-off-by: Sergiy Poplavskyi <[email protected]>

tomkerkhove · 2020-09-10T12:34:32Z

That's certainly ok for me @spoplavskiy, sorry for only noticing now!

spoplavskiy · 2020-09-10T12:38:03Z

That's certainly ok for me @spoplavskiy, sorry for only noticing now!

@tomkerkhove , I have created a new PR: #250

spoplavskiy requested review from ahmelsayed, jeffhollan, tomkerkhove and zroubalik as code owners September 4, 2020 07:05

spoplavskiy mentioned this pull request Sep 4, 2020

[v2] Added Azure Log Analytics scaler kedacore/keda#1085

Merged

4 tasks

tomkerkhove reviewed Sep 4, 2020

View reviewed changes

spoplavskiy requested a review from tomkerkhove September 4, 2020 15:41

tomkerkhove approved these changes Sep 7, 2020

View reviewed changes

tomkerkhove assigned ahmelsayed and zroubalik Sep 7, 2020

TsuyoshiUshio and others added 15 commits September 10, 2020 11:47

[v2] Update scaled job (#220)

4f6ebc6

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Provide redirects for dead links (#230)

4a54dbd

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Remove localhost that is not used on ScaledJob (#232)

8ee8a7b

Signed-off-by: Tsuyoshi Ushio <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

modify YAML deploy instructions for v2 (#233)

bc37b71

Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

specify VERSION with make deploy (#234)

e81f8b4

Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Fix links to ScaledObject and ScaledJob api (#236)

4c45412

Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Provide "Give KEDA 2.0 (Beta) a test drive" blog post (#226)

f32dd3e

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Add documentation for known GKE issue detailed in issue 515 (#237)

67cb894

Signed-off-by: Danny Seymour <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Added Azure Log Analytics scaler documentation

134d589

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

2ad0d7c

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

31ce036

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

f894f2d

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

4ca142d

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

87c7857

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

spoplavskiy added 3 commits September 10, 2020 11:47

Changed metadata parameters according to changes in a scaler

fe481ed

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Added 'FromEnv' description

f5a266a

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Changed query parameter to multiline in yaml examples

ed1ca6e

Signed-off-by: Sergiy Poplavskyi <[email protected]>

spoplavskiy and others added 22 commits September 10, 2020 12:50

Revert "Add documentation for known GKE issue detailed in issue 515 (#…

5a8413f

…237)" This reverts commit 67cb894.

Revert changes, caused by incorrent signoff

7cdde03

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Revert "Add documentation for known GKE issue detailed in issue 515 (#…

c4b3308

…237)" This reverts commit 67cb894. Signed-off-by: Sergiy Poplavskyi <[email protected]>

Revert changes, caused by incorrent signoff

1bd5fc2

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Merge branch 'master' of https://github.com/spoplavskiy/keda-docs

7af3fa5

Signed-off-by: Sergiy Poplavskyi <[email protected]>

reverting to commit ed1ca6e

bcd128a

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Added Azure Log Analytics scaler documentation

b4ac2cc

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

64f752d

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

0e4bfc9

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

07b9af8

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

32348cd

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

bd8c905

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

6d51b57

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

4e7a5c4

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

f5bd61b

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Changed Authentication section to be more fluent, added query result …

718524b

…screenshot Signed-off-by: Sergiy Poplavskyi <[email protected]>

Update content/docs/2.0/scalers/azure-log-analytics.md

013fd80

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Sergiy Poplavskyi <[email protected]>

Added Azure Log Analytics scaler in blog post

de77d84

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Changed metadata parameters according to changes in a scaler

90fe529

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Added 'FromEnv' description

f25937a

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Changed query parameter to multiline in yaml examples

ab573e0

Signed-off-by: Sergiy Poplavskyi <[email protected]>

Rebase branch

b599bb8

Signed-off-by: Sergiy Poplavskyi <[email protected]>

spoplavskiy closed this Sep 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Azure Log Analytics scaler documentation #244

Added Azure Log Analytics scaler documentation #244

spoplavskiy commented Sep 4, 2020 •

edited by tomkerkhove

Loading

tomkerkhove left a comment

tomkerkhove Sep 4, 2020

tomkerkhove Sep 4, 2020

spoplavskiy Sep 4, 2020

tomkerkhove Sep 7, 2020

ahmelsayed Sep 10, 2020

tomkerkhove Sep 10, 2020

tomkerkhove left a comment

tomkerkhove Sep 7, 2020

tomkerkhove commented Sep 7, 2020

tomkerkhove commented Sep 7, 2020 •

edited

Loading

spoplavskiy commented Sep 7, 2020

zroubalik commented Sep 10, 2020

tomkerkhove commented Sep 10, 2020

spoplavskiy commented Sep 10, 2020 •

edited

Loading

spoplavskiy commented Sep 10, 2020

tomkerkhove commented Sep 10, 2020

spoplavskiy commented Sep 10, 2020

Added Azure Log Analytics scaler documentation #244

Added Azure Log Analytics scaler documentation #244

Conversation

spoplavskiy commented Sep 4, 2020 • edited by tomkerkhove Loading

tomkerkhove left a comment

Choose a reason for hiding this comment

tomkerkhove Sep 4, 2020

Choose a reason for hiding this comment

tomkerkhove Sep 4, 2020

Choose a reason for hiding this comment

spoplavskiy Sep 4, 2020

Choose a reason for hiding this comment

tomkerkhove Sep 7, 2020

Choose a reason for hiding this comment

ahmelsayed Sep 10, 2020

Choose a reason for hiding this comment

tomkerkhove Sep 10, 2020

Choose a reason for hiding this comment

tomkerkhove left a comment

Choose a reason for hiding this comment

tomkerkhove Sep 7, 2020

Choose a reason for hiding this comment

tomkerkhove commented Sep 7, 2020

tomkerkhove commented Sep 7, 2020 • edited Loading

spoplavskiy commented Sep 7, 2020

zroubalik commented Sep 10, 2020

tomkerkhove commented Sep 10, 2020

spoplavskiy commented Sep 10, 2020 • edited Loading

spoplavskiy commented Sep 10, 2020

tomkerkhove commented Sep 10, 2020

spoplavskiy commented Sep 10, 2020

spoplavskiy commented Sep 4, 2020 •

edited by tomkerkhove

Loading

tomkerkhove commented Sep 7, 2020 •

edited

Loading

spoplavskiy commented Sep 10, 2020 •

edited

Loading