Update Azure Service Bus documentation for queueLength -> messageCount spec changes #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankrause
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
Replace "queueLength" with "messageCount" per a recent commit to the Service Bus scaler logic. Signed-off-by: ankrause <[email protected]>
|
I'll close this as I see that it's correct in v2.2, but if you google search for the scaler then the indexed page is 1.4. The "Click here for latest" button will take you to the 2.2 version of the page, but manually selecting a version will take you to the base docs page (rather than respecting relative path) and the dropdown shows (latest) next to whichever version you have selected. Just overall a bit odd and hinges on clicking the yellow button for an optimal experience. Because queueLength and messageCount are optional (default to 5) it's easy to look at the page and make the mistake thinking you have set the scale count when really it just defaults to 5 if you use the wrong property for the wrong version of the scaler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "queueLength" with "messageCount" per a recent commit to the Service Bus scaler logic.
The PR in question is #1138 in KEDA.