Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename queueLength to messageCount for Azure Service Bus scaler #1138

Merged
merged 8 commits into from
Sep 11, 2020
Merged

Rename queueLength to messageCount for Azure Service Bus scaler #1138

merged 8 commits into from
Sep 11, 2020

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Sep 10, 2020 •
edited
Loading

Signed-off-by: Tom Kerkhove [email protected]

Rename queueLength to messageCount for Azure Service Bus scaler since this is confusing when using topics.

Checklist

I'll open a doc PR when this is agreed and merged. (depends on this PR as well)

Relates to #1109

@tomkerkhove
Fix code formatting
c582756 
Signed-off-by: Tom Kerkhove <[email protected]>
@zroubalik
Copy link
Member

@tomkerkhove nice, could you please add a test case for this property?

@tomkerkhove
Provide tests
477db51 
Signed-off-by: Tom Kerkhove <[email protected]>
@tomkerkhove
Copy link
Member Author

Didn't run them locally and don't know how to write Go, but this will work for sure!

ahmelsayed
ahmelsayed approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ahmelsayed
Copy link
Contributor

actually looks like a test case (TestAzServiceBusGetMetricSpecForScaling) is failing. I think the order of the test data in parseServiceBusMetadataDataset has changed, but azServiceBusMetricIdentifiers, which is used in that test depends on that order.

@tomkerkhove tomkerkhove mentioned this pull request Sep 11, 2020
Merged
1 task
@zroubalik zroubalik merged commit db1907e into kedacore:v2 Sep 11, 2020
@tomkerkhove tomkerkhove deleted the sb-message-count branch November 19, 2020 10:41
@ankrause ankrause mentioned this pull request May 1, 2021
Closed
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@BenjaminHerbert
docs: Fix typo ScaledObejct -> ScaledObject (kedacore#1138)
7d415d1 
Signed-off-by: Benjamin Herbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomkerkhove @zroubalik @ahmelsayed