Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus scaler add option to ignore null value #769

Conversation

bamboo12366
Copy link
Contributor

@bamboo12366 bamboo12366 commented May 29, 2022

Signed-off-by: Xinzhu Zhou [email protected]

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#3065
Relates to kedacore/keda#3064
Relates to kedacore/keda#3073

@netlify
Copy link

netlify bot commented May 29, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit e1d2538
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6295d3c31ada95000908ebc0
😎 Deploy Preview https://deploy-preview-769--keda.netlify.app/docs/2.8/scalers/prometheus
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Xinzhu Zhou <[email protected]>
@bamboo12366 bamboo12366 changed the title Bamboo/prometheus scaler add option to ignore null value prometheus scaler add option to ignore null value May 30, 2022
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

content/docs/2.8/scalers/prometheus.md Outdated Show resolved Hide resolved
Signed-off-by: Xinzhu Zhou <[email protected]>
@JorTurFer JorTurFer requested a review from tomkerkhove May 31, 2022 19:28
@tomkerkhove tomkerkhove merged commit 6be8451 into kedacore:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants