-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus scaler add option to ignore null value #769
Merged
tomkerkhove
merged 5 commits into
kedacore:main
from
bamboo12366:bamboo/prometheus-scaler-add-option-to-ignore-null-value
Jun 1, 2022
Merged
prometheus scaler add option to ignore null value #769
tomkerkhove
merged 5 commits into
kedacore:main
from
bamboo12366:bamboo/prometheus-scaler-add-option-to-ignore-null-value
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinzhu Zhou <[email protected]>
Signed-off-by: Xinzhu Zhou <[email protected]>
bamboo12366
requested review from
jeffhollan,
ahmelsayed,
tomkerkhove,
zroubalik and
JorTurFer
as code owners
May 29, 2022 08:33
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4 tasks
JorTurFer
reviewed
May 29, 2022
Signed-off-by: Xinzhu Zhou <[email protected]>
bamboo12366
changed the title
Bamboo/prometheus scaler add option to ignore null value
prometheus scaler add option to ignore null value
May 30, 2022
tomkerkhove
suggested changes
May 30, 2022
Signed-off-by: Xinzhu Zhou <[email protected]>
zroubalik
reviewed
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
Signed-off-by: Xinzhu Zhou <[email protected]>
zroubalik
approved these changes
May 31, 2022
JorTurFer
approved these changes
May 31, 2022
tomkerkhove
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinzhu Zhou [email protected]
Provide a description of what has been changed
Checklist
Relates to kedacore/keda#3065
Relates to kedacore/keda#3064
Relates to kedacore/keda#3073