Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus scaler add option to ignore null value #769

Merged
merged 5 commits into from
Jun 1, 2022
Merged

prometheus scaler add option to ignore null value #769

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5b0efa
update doc for prometheus scaler
bamboo12366 May 29, 2022
a287c42
revert params.version
bamboo12366 May 29, 2022
3e94d57
update according to review
bamboo12366 May 30, 2022
4f5ea76
use true/false insteads of enable/disable
bamboo12366 May 30, 2022
e1d2538
fix typo
bamboo12366 May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion content/docs/2.8/scalers/prometheus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ triggers:
# Optional fields:
namespace: example-namespace # for namespaced queries, eg. Thanos
cortexOrgId: my-org # Optional. X-Scope-OrgID header for Cortex.
ignoreNullValues: disable # Default is enable, which means ignoring the empty value list from prometheus. Set to disable the scaler will return error when prometheus target is lost
JorTurFer marked this conversation as resolved.
Show resolved Hide resolved
```

**Parameter list:**
Expand All @@ -33,6 +34,7 @@ triggers:
- `threshold` - Value to start scaling for.
- `namespace` - A namespace that should be used for namespaced queries. These are required by some highly available Prometheus setups, such as [Thanos](https://thanos.io). (Optional)
- `cortexOrgId` - The `X-Scope-OrgID` header to query multi tenant [Cortex](https://cortexmetrics.io/). (Optional)
- `ignoreNullValues` - Value to reporting error when Prometheus target is lost (Values: `enable`,`disable`, Default: `enable`, Optional)

### Authentication Parameters

Expand Down Expand Up @@ -289,4 +291,4 @@ spec:
authModes: "tls,basic"
authenticationRef:
name: keda-prom-creds
```
```