New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested variable override #18

Merged

cappuc merged 2 commits into main from nested-variable-override

May 10, 2024

Contributor

cappuc commented May 3, 2024 •

edited

Loading

With this PR we can override a nested variable (for example product.name) without overriding the entire variable.

There are breaking changes:

RenderContext::findVariable will be renamed RenderContext::findVariables and will return an array of matching variables (sorted by priority)
RenderContext::lookupAndEvaluate has been removed (the evaluation has been moved to VariableLookup)

cappuc added 2 commits

May 3, 2024 15:14


          nested variable override test

c280a43


          support nested variable override

3f70b94

cappuc merged commit 10bb250 into main

16 checks passed

cappuc deleted the nested-variable-override branch

May 10, 2024 12:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet