New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced Template state #3

Merged

cappuc merged 3 commits into main from refactoring

Sep 1, 2023

Contributor

cappuc commented Sep 1, 2023 •

edited

Loading

Removed ParseContext from tag state, so its no longer available during render phase
Update render tag to parse partial template in the parse phase instead of render phase
Share partials cache between parse context and render context (saving them in the root Template after parsing)
Renamed parse method of TemplateFactory to parseString and added parseTemplate method (it parses a template from filesystem)

cappuc added 3 commits

September 1, 2023 13:10


          removed parse context from tag state

2170c79


          share partials cache between parse and render context

1ffbcbc


          parse template from filesytem

89565f9

cappuc merged commit 437f138 into main

cappuc deleted the refactoring branch

September 4, 2023 10:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet