This repository has been archived by the owner on Oct 2, 2018. It is now read-only.
play-card-as-player test #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenan-rhoton
suggested changes
Sep 3, 2018
kenan-rhoton
reviewed
Sep 3, 2018
|
Also invalid player-id/game-id |
kenan-rhoton
reviewed
Sep 4, 2018
backend/src/api/base.clj
Outdated
| @@ -13,12 +13,16 @@ | |||
| (player-view/get-game-as-player (persistence/fetch-game game-id) player-id)) | |||
|
|
|||
| (defn play-card-as-player | |||
| "Plays a card give and returns the game sate as seen by the player" | |||
| [game-id player-id card-id row-id & target] | |||
| (let [game-state (persistence/fetch-game game-id)] | |||
| (if (= (:status (get-game game-id player-id)) messages/play) | |||
There was a problem hiding this comment.
What happens if game-state is nil? (Not in the database)
Masclins
commented
Sep 4, 2018
| p2 (:player-id (base/add-player game-id))] | ||
|
|
||
| (expect {:error messages/invalid-id} | ||
| (base/play-card-as-player 9999999999 p1 0 0)) |
There was a problem hiding this comment.
@kenan-rhoton apparently "mocking" is making this test not as good as it should be
Masclins
commented
Sep 4, 2018
| [game-id player-id card-id row-id & target] | ||
| (let [game-state (persistence/fetch-game game-id)] | ||
| (if (and (= game-id (:game-id game-state)) | ||
| (or (= player-id (first (:player-ids game-state))) | ||
| (= player-id (second (:player-ids game-state))))) |
There was a problem hiding this comment.
I'm pretty sure this can be done prettier... But how?
There was a problem hiding this comment.
I'll open an issue to clean this up cause it would involve changes to mocking, so I dont forget
Closed
kenan-rhoton
approved these changes
Sep 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should complete the tests of current
api/base.clj, solving a point from #55Resolves #97 (at least the needed messages we came up with)