-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PHP 8 #2158
Merged
Merged
Support for PHP 8 #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # composer.json # composer.lock
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
============================================
- Coverage 92.79% 92.67% -0.12%
- Complexity 6738 6740 +2
============================================
Files 616 616
Lines 20135 20142 +7
============================================
- Hits 18684 18667 -17
- Misses 1451 1475 +24
|
# Conflicts: # UPGRADING.md # src/Utils/LocaleHelper.php
# Conflicts: # .github/workflows/linting.yaml # composer.json # composer.lock
# Conflicts: # UPGRADING.md # composer.json # composer.lock # src/Repository/ActivityRepository.php # src/Repository/CustomerRepository.php # src/Repository/ProjectRepository.php
# Conflicts: # UPGRADING.md
kevinpapst
added a commit
that referenced
this pull request
Jul 13, 2021
painful 66 commits later: required PHP version bumped to 7.3, plugin updates using migrations necessary!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LOOKING FOR HELP WITH TESTING!
TODO BC breaks
FIXED
PHP_CS_FIXER_IGNORE_ENV=1
syntaxChecklist
composer code-check
)